Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751895AbdFHVKM (ORCPT ); Thu, 8 Jun 2017 17:10:12 -0400 Received: from outils.crapouillou.net ([89.234.176.41]:56302 "EHLO outils.crapouillou.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751427AbdFHVKL (ORCPT ); Thu, 8 Jun 2017 17:10:11 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 08 Jun 2017 23:10:06 +0200 From: Paul Cercueil To: Stephen Boyd Cc: Ralf Baechle , Michael Turquette , Rob Herring , Paul Burton , Maarten ter Huurne , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, linux-clk@vger.kernel.org Subject: Re: [PATCH 04/15] clk: Add Ingenic jz4770 CGU driver In-Reply-To: <20170607205943.GO20170@codeaurora.org> References: <20170607200439.24450-1-paul@crapouillou.net> <20170607200439.24450-5-paul@crapouillou.net> <20170607205943.GO20170@codeaurora.org> Message-ID: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 874 Lines: 30 Hi, >> + register_syscore_ops(&jz4770_cgu_pm_ops); >> +#endif >> +} >> +CLK_OF_DECLARE(jz4770_cgu, "ingenic,jz4770-cgu", jz4770_cgu_init); > > Any reason this can't be a platform driver? Please add a comment > above CLK_OF_DECLARE describing what is preventing that. It would probably be possible, if we cared about having a platform driver. But we will only ever probe it from devicetree, just like with the already existing jz4740-cgu and jz4780-cgu drivers. >> diff --git a/include/dt-bindings/clock/jz4770-cgu.h >> b/include/dt-bindings/clock/jz4770-cgu.h >> new file mode 100644 >> index 000000000000..54b8b2ae4a73 >> --- /dev/null >> +++ b/include/dt-bindings/clock/jz4770-cgu.h > > Can you split this file off into a different patch? That way clk > tree can apply clk patches on top of a stable branch where this > file lives by itself. Sure. Thanks, - Paul