DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7EA122CAF
Date: Thu, 8 Jun 2017 17:39:46 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Shuah Khan <shuahkh@osg.samsung.com>
Cc: Shuah Khan <shuah@kernel.org>, Masami Hiramatsu <mhiramat@kernel.org>,
        linux-kselftest@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/7] selftests/ftrace: Some improvements of ftracetest
Message-ID: <20170608173946.7c9308f2@gandalf.local.home>
In-Reply-To: <9be74d50-aee5-4771-a62c-e04156176263@osg.samsung.com>
References: <149551934796.30231.12544755801380678045.stgit@devbox>
        <4b0b2ac8-dfba-abd9-3dba-bbe73c22f79f@kernel.org>
        <20170607185628.452a11a1@gandalf.local.home>
        <8f974157-c2e5-9b39-c55b-b637d6e7814f@osg.samsung.com>
        <20170608133743.4720e2bc@gandalf.local.home>
        <8bcf5a87-812a-6ceb-7fa4-ea2d33d4e717@osg.samsung.com>
        <20170608170844.134e1158@gandalf.local.home>
        <9a2b4e46-a545-b862-2517-472f364a68b3@osg.samsung.com>
        <20170608172627.3dab319e@gandalf.local.home>
        <9be74d50-aee5-4771-a62c-e04156176263@osg.samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1129
Lines: 28

On Thu, 8 Jun 2017 15:33:39 -0600
Shuah Khan <shuahkh@osg.samsung.com> wrote:


> > Note, when a bug is found, we do add the reproducer to ftracetest. So
> > depending on whether you have the latest stable, or the stable has a
> > fix, ftracetest can cause the machine to crash on older releases.  
> 
> Yeah - that could be problem, I would worry more if ftracetest can be run
> as a non-root user. As ftracetest is intrusive in nature just like the timer
> tests, we could say user needs to be aware.
> 
> If the outcome isn't desirable, we could run ftracetest conditionally as
> a last resort. I think it is important for it to be run as part of kselftest
> suite run.

Well, I wouldn't worry too much. It shouldn't do any damage. And
anything that can trigger a bug in previous kernels should be
backported as well to the stable releases. Everyone runs the latest
stable kernels, right?

Also, did you see my reply about having the right config? You have
HIST_TRIGGERS undefined but yet the histogram trigger tests all pass in
your report.

One more thing, is this 100% reproducible. That is, does it always fail?

-- Steve