Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751947AbdFHVsJ (ORCPT ); Thu, 8 Jun 2017 17:48:09 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:57791 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751803AbdFHVsD (ORCPT ); Thu, 8 Jun 2017 17:48:03 -0400 X-Greylist: delayed 70457 seconds by postgrey-1.27 at vger.kernel.org; Thu, 08 Jun 2017 17:48:03 EDT X-Originating-IP: 74.125.82.41 MIME-Version: 1.0 In-Reply-To: <1496896364-27153-1-git-send-email-yanhaishuang@cmss.chinamobile.com> References: <1496896364-27153-1-git-send-email-yanhaishuang@cmss.chinamobile.com> From: Pravin Shelar Date: Thu, 8 Jun 2017 14:47:59 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 1/2] ip_tunnel: fix potential issue in ip_tunnel_rcv To: Haishuang Yan Cc: "=David S. Miller" , Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy , Linux Kernel Network Developers , linux-kernel@vger.kernel.org, Pravin B Shelar Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 561 Lines: 17 On Wed, Jun 7, 2017 at 9:32 PM, Haishuang Yan wrote: > When ip_tunnel_rcv fails, the tun_dst won't be freed, so call > dst_release to free it in error code path. > > CC: Pravin B Shelar > Fixes: 2e15ea390e6f ("ip_gre: Add support to collect tunnel metadata.") > Signed-off-by: Haishuang Yan > > --- > Changes in v2: > - Add the the missing Fixes information > Changes in v3: > - Free tun_dst from error code path > --- Acked-by: Pravin B Shelar