DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B14122CAF
Date: Thu, 8 Jun 2017 17:51:44 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Shuah Khan <shuahkh@osg.samsung.com>
Cc: Shuah Khan <shuah@kernel.org>, Masami Hiramatsu <mhiramat@kernel.org>,
        linux-kselftest@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/7] selftests/ftrace: Some improvements of ftracetest
Message-ID: <20170608175144.205894cb@gandalf.local.home>
In-Reply-To: <052a7347-be6e-42e2-de5e-6f5849fa1e8e@osg.samsung.com>
References: <149551934796.30231.12544755801380678045.stgit@devbox>
        <4b0b2ac8-dfba-abd9-3dba-bbe73c22f79f@kernel.org>
        <20170607185628.452a11a1@gandalf.local.home>
        <8f974157-c2e5-9b39-c55b-b637d6e7814f@osg.samsung.com>
        <20170608133743.4720e2bc@gandalf.local.home>
        <8bcf5a87-812a-6ceb-7fa4-ea2d33d4e717@osg.samsung.com>
        <20170608170844.134e1158@gandalf.local.home>
        <9a2b4e46-a545-b862-2517-472f364a68b3@osg.samsung.com>
        <20170608172627.3dab319e@gandalf.local.home>
        <9be74d50-aee5-4771-a62c-e04156176263@osg.samsung.com>
        <20170608173946.7c9308f2@gandalf.local.home>
        <052a7347-be6e-42e2-de5e-6f5849fa1e8e@osg.samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1008
Lines: 27

On Thu, 8 Jun 2017 15:44:08 -0600
Shuah Khan <shuahkh@osg.samsung.com> wrote:

> > Also, did you see my reply about having the right config? You have
> > HIST_TRIGGERS undefined but yet the histogram trigger tests all pass in
> > your report.  
> 
> I did see that one. Didn't get a chance to look at that yet. Do you expect
> the tests to be skipped in this case? Could it be that tests aren't run?
> I will look at this and let you know what I find on my test system.

Your first email showed that they passed, which would be hard to do
since the feature is not even enabled. ftracetest is very much set up
to look at the existing pseudo files to determine if a feature exists
or not, and if it does not, it returns "UNSUPPORTED". If it returned
PASSED when the feature is not enabled, that would be a big time bug in
the test.

> 
> > 
> > One more thing, is this 100% reproducible. That is, does it always fail?
> >   
> Failed the two times I tried.

Great to hear. I like reproducibility :-)

-- Steve