Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751998AbdFHWUi (ORCPT ); Thu, 8 Jun 2017 18:20:38 -0400 Received: from ozlabs.org ([103.22.144.67]:45845 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751591AbdFHWUh (ORCPT ); Thu, 8 Jun 2017 18:20:37 -0400 From: Michael Ellerman To: Michael Bringmann , Benjamin Herrenschmidt , Paul Mackerras , Nathan Fontenot , Sahil Mehta , John Allen , Michael Bringmann , "Alastair D'Silva" , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: Resend [PATCH] powerpc/hotplug-mem: Fix aa_index match bug for hotplug In-Reply-To: References: User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Fri, 09 Jun 2017 08:20:34 +1000 Message-ID: <87tw3qi0jx.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 731 Lines: 21 Michael Bringmann writes: > When adding or removing memory, the aa_index (affinity value) for the > memblock must also be converted to match the endianness of the rest > of the 'ibm,dynamic-memory' property. Otherwise, subsequent retrieval > of the attribute will likely lead to non-existent nodes, followed by > using the default node in the code inappropriately. > > Note: This is a bug that we would likely want to see fixed in stable > circa v4.1+. I merged this a week ago: https://lists.ozlabs.org/pipermail/linuxppc-dev/2017-June/158426.html It was annotated: Fixes: 5f97b2a0d176 ("powerpc/pseries: Implement memory hotplug add in the kernel") Cc: stable@vger.kernel.org # v4.1+ cheers