Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751870AbdFHWYQ (ORCPT ); Thu, 8 Jun 2017 18:24:16 -0400 Received: from mail.kmu-office.ch ([178.209.48.109]:50673 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751478AbdFHWYO (ORCPT ); Thu, 8 Jun 2017 18:24:14 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Thu, 08 Jun 2017 15:23:05 -0700 From: Stefan Agner To: Han Xu Cc: shawnguo@kernel.org, kernel@pengutronix.de, sboyd@codeaurora.org, "A.S. Dong" , dwmw2@infradead.org, computersforpeace@gmail.com, boris.brezillon@free-electrons.com, marek.vasut@gmail.com, richard@nod.at, robh+dt@kernel.org, mark.rutland@arm.com, fabio.estevam@freescale.com, "LW@KARO-electronics.de" , linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 2/3] ARM: dts: imx7: add GPMI NAND and APBH DMA In-Reply-To: <9d66efda-d7c1-89a2-e163-c86056e08fb1@nxp.com> References: <151ddece1e1427d0b69c4ff11b86a69b6a035d0d.1496730576.git-series.stefan@agner.ch> <9d66efda-d7c1-89a2-e163-c86056e08fb1@nxp.com> Message-ID: <956085c409415e76adcf4b429d8dc0b5@agner.ch> User-Agent: Roundcube Webmail/1.2.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1941 Lines: 59 On 2017-06-07 08:33, Han Xu wrote: > On 06/06/2017 01:30 AM, Stefan Agner wrote: >> Add i.MX 7 APBH DMA and GPMI NAND modules. >> >> Signed-off-by: Stefan Agner >> --- >> arch/arm/boot/dts/imx7s.dtsi | 32 ++++++++++++++++++++++++++++++++ >> 1 file changed, 32 insertions(+) >> >> diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi >> index c4f12fd..d71acd8 100644 >> --- a/arch/arm/boot/dts/imx7s.dtsi >> +++ b/arch/arm/boot/dts/imx7s.dtsi >> @@ -995,5 +995,37 @@ >> status = "disabled"; >> }; >> }; >> + >> + dma_apbh: dma-apbh@33000000 { >> + compatible = "fsl,imx7d-dma-apbh", "fsl,imx28-dma-apbh"; >> + reg = <0x33000000 0x2000>; >> + interrupts = , >> + , >> + , >> + ; >> + interrupt-names = "gpmi0", "gpmi1", "gpmi2", "gpmi3"; >> + #dma-cells = <1>; >> + dma-channels = <4>; >> + clocks = <&clks IMX7D_NAND_USDHC_BUS_RAWNAND_CLK>; >> + clock-names = "dma_apbh_bch", "dma_apbh_io"; > > please remove the clock names, I am good with all other changes. Oh missed that, will do and send v6. -- Stefan >> + }; >> + >> + gpmi: gpmi-nand@33002000{ >> + compatible = "fsl,imx7d-gpmi-nand"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + reg = <0x33002000 0x2000>, <0x33004000 0x4000>; >> + reg-names = "gpmi-nand", "bch"; >> + interrupts = ; >> + interrupt-names = "bch"; >> + clocks = <&clks IMX7D_NAND_RAWNAND_CLK>, >> + <&clks IMX7D_NAND_USDHC_BUS_RAWNAND_CLK>; >> + clock-names = "gpmi_io", "gpmi_bch_apb"; >> + dmas = <&dma_apbh 0>; >> + dma-names = "rx-tx"; >> + status = "disabled"; >> + assigned-clocks = <&clks IMX7D_NAND_ROOT_SRC>; >> + assigned-clock-parents = <&clks IMX7D_PLL_ENET_MAIN_500M_CLK>; >> + }; >> }; >> };