Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751532AbdFIFMo (ORCPT ); Fri, 9 Jun 2017 01:12:44 -0400 Received: from mail-he1eur01on0110.outbound.protection.outlook.com ([104.47.0.110]:35616 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751084AbdFIFMl (ORCPT ); Fri, 9 Jun 2017 01:12:41 -0400 Authentication-Results: synopsys.com; dkim=none (message not signed) header.d=none;synopsys.com; dmarc=none action=none header.from=axentia.se; Subject: Re: [PATCH v10 1/6] i2c: designware: Cleaning and comment style fixes. To: Luis Oliveira , wsa@the-dreams.de, robh+dt@kernel.org, mark.rutland@arm.com, jarkko.nikula@linux.intel.com, andriy.shevchenko@linux.intel.com, mika.westerberg@linux.intel.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ramiro.Oliveira@synopsys.com, Joao.Pinto@synopsys.com, CARLOS.PALMINHA@synopsys.com References: <4fb5f66dafc24e3213aaa8fc93fa12fecb6d6aa1.1496942505.git.lolivei@synopsys.com> From: Peter Rosin Organization: Axentia Technologies AB Message-ID: <5bc3077b-2e4c-eb27-bca1-b7cbfc2dec01@axentia.se> Date: Fri, 9 Jun 2017 07:12:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <4fb5f66dafc24e3213aaa8fc93fa12fecb6d6aa1.1496942505.git.lolivei@synopsys.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [81.224.171.159] X-ClientProxiedBy: AM3PR07CA0125.eurprd07.prod.outlook.com (2603:10a6:207:8::11) To VI1PR0202MB2559.eurprd02.prod.outlook.com (2603:10a6:801:6::10) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI1PR0202MB2559: X-MS-Office365-Filtering-Correlation-Id: 5f9d23f3-c1f1-4b81-a3e9-08d4aef62469 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075);SRVR:VI1PR0202MB2559; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2559;3:EdiShNcMrCyTfTA7WsaHQkL3yXyxDuz5834ciI2bOOhdOXN6Ny4MwH59ZFdHrXFLcg0BWsHadm873oSDY9a037v2cMtvQk54msHSYRescZwLKqlqKv5J4Pd1x7NiykqMgkpIaZaA7L8rqaX/N/GG2/kxtljzX9kQCKnS0emmCcESBd9dgvWN3V+9sNoaN3PD9UvIKdIBEwDfwtuwV530K0TuKDF73rrZJ0a7+tJolTUJp1sRlOLXA+v9DESpmf/FZRu6rlHGJK2BzyMkqJi8NdSGGzjBXCo/x7kTpCDi3II=;25:7+KVkS4IBZeCBVzaZUVuIRe5Fl2SRD70EPzQWu+MYPYJ0pyzVJH3mAHVRRxCut0kmvSyRag5QxRsV4ThoS0vbmmwMX5KV32wJKTyvpCWGzeEqGaZ54vXhDYX9CsTUyf9YgqOyUSujTGFh0p6tO4AguW3iGSo+4jbaFEEM1aOotYjfCclcC65eLXYrqwO0GXfQwkcPZWWYJXaZNyP2baJJxpmH2Bnfx3GKOaf0YPY9sHNjRi926TVS4AlF+SoQZ4LXoMKsl2QIDorkqZCk6nfciqYZIcs8DTcw622eStFeFI/AQRzm865h66kt0Y41F8Qe9R5m55RWoGlP80wJGUn4WCoDMR4WBN7jXodDI2tajaSIdzC2M/ht5lMyDTwyk3CfCgLJbdoPuqeJDJidcMyV7bFUuAzBSx4jhUAx5mVgpeK9Mssh3YVUB5myKlvNMg1PDCpvZIQ+gpOepS2j9VN2hbvyPdI4ExfjOCqPF5joyY= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2559;31:iImkLDS3uPGTH1timo0U1Mj+jJoMzZQeQp5PxhmBhg2dh8HgY482kL3gW1nh9CHG1oyT2xBAD3EQGfVyVP5WCTfLYpc5/MpGIkLWnSYw+KqFSbmscfwpOKaVkQH0WQXrBsF8TDfjcJEi+pWDXhhq+noV/19wPZaAUmxc4VO6NJ+3U1v8CMYK/eEWumIH0tnXkfpQ+ESAoku4HRHjU892sfPxnbOjeQ4b0CRP+PEVu9US+k2q9yEBoU7oSjFN00k78EWUMN2T0FvJ3IMgYlhM8A== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(3002001)(10201501046)(93006095)(93001095)(6041248)(20161123562025)(20161123555025)(20161123560025)(20161123564025)(2016111802025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(6043046)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:VI1PR0202MB2559;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:VI1PR0202MB2559; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtWSTFQUjAyMDJNQjI1NTk7NDpoalhYQVRjU0VUdmtmUTMzZ0ZKY29RTTZZ?= =?utf-8?B?a3FkY3BpQUxQTGNGaWViTm11Tjd6MnlKdCtoSUxmeXVkNE9XL1UzSnN4dFlI?= =?utf-8?B?U0dnc0RuR292YWh1enRlaWFaMS9HdkpQS0k0ellQNDBvNDR1azhVRUlYTngv?= =?utf-8?B?dkpmTkgzR3BiWUtiZW1pdkg4RU1GaWpJcWtIa2NOUHVuTGtHdzJqWUkzYXp0?= =?utf-8?B?a1E5cWdCd3ZEb3BMN0hDTGd2a3U0VC9ZSlliTldld2N5d2pxdWNjSEh0S1Bl?= =?utf-8?B?VXRjZ0V2bHlzd0tSVlQrWXFtMXVURmJoZ3hpQzhydER4N2UwU005MmRpQUlO?= =?utf-8?B?c3VTMXJ5VnJkNnh5bE8wN0owTkV0Z2prSStEOU9ESlM1ekhnWnd4dkJ0cjZz?= =?utf-8?B?OWlnNzZIRHJJSi93VlEvVDhqWEhrNkpOcllBUnllUlR5WWxXaXNVT24wMHlS?= =?utf-8?B?emxXQ0pVQVI0eGhneWdZSGgySGRrRVlneG1oRUJaZjNESGNMQ2RJTyttN2NK?= =?utf-8?B?WVNQdGt0NXBqS0V4dzM3V2VwRVpPaGhGb1R4L2duUm0xenBIamZROE8wYkI2?= =?utf-8?B?dTZoa3BnSEMwZ3NEK2hvLy94aUVyQ1BjV3U0Sjd3OHBXNy9ZbWE2blc5dDFm?= =?utf-8?B?eW1LVS85L0RaSkw4VTBpckI2amlRUmpGZGF3bVc3RmZpOGwwUVRhNzlERkMr?= =?utf-8?B?VmEyZTl0UjdnNXBQRERNampjYUVzcU96Y3NzOTNZM2dVaU9XRXJveXJXaC9u?= =?utf-8?B?TWVVNnB3MTdVSjNOYWU4Q3pSZjVhT2l0UHBxV1dZKy83dy9FemRmWG9uS3hU?= =?utf-8?B?UC9hKzZHcU9ZN3IrQ0E2OUVVNVVjSS8yeXNPdnlzODkzekc0ZnRmYjZRMis3?= =?utf-8?B?SHdOa0JxNzBVYnpzWk1SWmEzVDM2UGw0cDNzT0MwWkVweWNoYzhhYmxxNU13?= =?utf-8?B?ZFhBME96Q09mUG14Njlua201cmw1T3dyckVmWHp2M1lFVEZtRmZLQlQ0Smgx?= =?utf-8?B?WFFCK05za2FvUC9VazBqQ0o0RXd2aEd2UEYxRjhEZDROcDdpNC9mdlM2RWdP?= =?utf-8?B?ci9TZjYrcGdWSXg3dHNrbGIyTW9DR0N0dlJ1cFlJZjBiZ0VkZmM4aEF5N0t6?= =?utf-8?B?eFRCNk93Rng3R2RsMGFmVzhPN01jOGhXV1VzREpNR3NmNHVYUnFpNE91Rmdu?= =?utf-8?B?TWlnNTg1UmlVbHBlUUxVQ3Q1SkxXN29nb0xZdm1tRGh2ZkFWVjlwem1BUnJE?= =?utf-8?B?eGNBU24xNVFHblRVNmV1dXhTNkUxTm5wZU1EZE5FRmxqTmJBYXpXbFZXS3k2?= =?utf-8?B?VW1zeUdsaVFtMkNtQ0MwUzNGMytrbGVqSFUzS1FydUxETGErTWxMYzlEUDJ0?= =?utf-8?B?bzViOWYxb2ZYYXhBL2hzbXhGbnBJcFI4ZWM1UVhUaEthMGpWUVQwZXFiSUtR?= =?utf-8?B?b2NvOG0wQUszRUpJN2RKRnBURjdIdlJZdmRGam54UzdxT1c1cDNsMGoxSXJG?= =?utf-8?B?eXVMZk85UThaR1VGK3BQL0E4YVVvT1NiTmVVSVlWdHpWTjlkZnNDSlgvb2FU?= =?utf-8?B?dlR1bVNmQWRpNlVwMVFWUHl4Sk1qYVY4RUpkaGRzNDYyUVVtRGZKSkxMYjRT?= =?utf-8?Q?m+6GGaP2eOPfgJ1r3PijA?= X-Forefront-PRVS: 03333C607F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(39450400003)(39400400002)(39830400002)(39410400002)(24454002)(377424004)(36756003)(64126003)(31686004)(189998001)(2906002)(42186005)(7736002)(305945005)(478600001)(50986999)(76176999)(54356999)(8676002)(81166006)(5660300001)(65826007)(2950100002)(6666003)(74482002)(229853002)(23676002)(33646002)(7416002)(38730400002)(3846002)(6246003)(86362001)(110136004)(230700001)(65806001)(66066001)(65956001)(77096006)(6486002)(53936002)(31696002)(117156002)(47776003)(4326008)(25786009)(3260700006)(53546009)(921003)(1121003)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR0202MB2559;H:[192.168.0.125];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtWSTFQUjAyMDJNQjI1NTk7MjM6eUt6VHhZQXlFZ2tQUytZOE9DdkYwcEhH?= =?utf-8?B?MDVoK09kSWRwZmR3dS9VTjlsTVEyajB6eWlmOEhUZml3bXlYMFpWZnBFM3RD?= =?utf-8?B?VWJWRTBrSEk4TTc4WmhjMm9nNTd6VVU5SVordnVZK0xFRE90WVNTc2ZscUw2?= =?utf-8?B?ejd1N0JhRjM2Rjh3L3ZjTkEwejc3UHNGQkZNamQ2SFUxenNWTllKY3E4Zkw2?= =?utf-8?B?N2lPeTIzeTR1eDA2TDljT0ZPR3lGVUx3THcvSjhDMjA0dEtmMGRHY2pMVzZs?= =?utf-8?B?dWJiVXg5Qy9Eby9yVHkxSlVoMUVac0trTlQzMHJPM1Zka3NobFBjQUN5RVZq?= =?utf-8?B?WTJvY0MyOEpCUWFJaG1mZmR0SnRhYUNHNFZEUWtJejNpTjZ1KzdIdnc1QjVS?= =?utf-8?B?dXM5NHBTZzhFdndtaFNWdlVadllrUVNBdEZSTU83MkQyU0kvbE94L3N0S2tK?= =?utf-8?B?MjVNaVVGSGZobHIrVDZ2cVpOWS9qSHg4ZUdZRTBDS0ZVRkRjYXlIUUIyYXI2?= =?utf-8?B?NnhzbUhOZVZ1VmhvcEdxNy9RVFRQeVh5UFhhSU9YRDhSVmpDdUNaN2NKeUU1?= =?utf-8?B?QmU0ZXF5OWhWbTJYRW5za2hzbytUYnJtSGNtMzlkUUdZbXdqQVArYXVNOXdS?= =?utf-8?B?Q1dLMUpYd3FFbTZkTnI3TEtQS1JaN1BxbVVHMGFUb0ROMENnQ3FOWTIzSHdv?= =?utf-8?B?THdyNDZKTlhlMkFhNzJuVzVzMCtEYXdBV29ZMWgxcm13MUtWQ0pESXdqUmdO?= =?utf-8?B?YU12S1JuT3NtSHVlRWZwY1FCZXR3NDV6dEZGNnRmVHdCVkFDcXNTbU9SSFZk?= =?utf-8?B?bk0xTFduUndRcndmMFBGM2I4YklTVXZxL243dGZTbURmN3R2YnFGc1M2VXZI?= =?utf-8?B?b2h2Z2FOSjFSMU1aMU5TRWQ3bGNBc2VVZnIxa08zVEZzcjdHSlQvNUgxbnNB?= =?utf-8?B?eTlwYnFaeldCcmZNMnh1NlExbjFlRWh4UkpRTGVxY0tMTW5DZEE5eEJWQWJo?= =?utf-8?B?ZHFQNVVOYzdIcng0UU9mUVlSVXV6UXlnY1BtOEVKdzkwYXphZGxOVW9rQ3V0?= =?utf-8?B?ODVRd1JCczFBWk1tYlVISHR2VHphNGxTUmF5RmgrNi9jWkNaaVQxRXdJOGk5?= =?utf-8?B?RnZEdTUyRnUzVmQxVTk3bHpBS2h1R0FJaUVVUUxZekFYbVJXbEhiWFJUSHNY?= =?utf-8?B?QWZyNUlENWl3bjRzdzllUkhyeTZydXdkdVJ6T1d5VkdHbE55YXpvWEVzenlt?= =?utf-8?B?dTFQVFBkQTNmaTNKdEdQRU9rWE1UMU9ZdGNRQmttTHdSb28wWEMxQjM4OTJE?= =?utf-8?B?UXlmL2Vycld5SWFGWGRGa3dvYStuUzJJNjFLYm9DREdROGl0Y2N0ZlhXYmRj?= =?utf-8?B?RzlEQ1JveHVDZWRUS0haNzhVdVQ3M3dSWDdvQmlOS0lJWW9sN0RqMGdzREpT?= =?utf-8?B?SE1uN1ROQm9qQ2Vsc3VoUld0YitQb0dxVW55bUpTTnR3Q2NhZWo1RlYvNmxC?= =?utf-8?B?T3B5aFdZWENLbmNpZEJKek5FUS9TM3JqVFFMdnNNM2xiUU14VGtpVFVWRDBk?= =?utf-8?B?U05MZklMVGFiSWJKTW9JNElMZUdjNEFETDYvUmdXTnA2dVE3ZnNzVGVXUHJi?= =?utf-8?B?enh1aG1xTzJoVlEzMW4raU5ackJBLzVLdS85d1k5Z295YmR5NGNXM3hFNHQw?= =?utf-8?B?WkxyRE1vTzVrK3JzS0dGMUI2RkRKWmV5NTVrTk8yLzJDUzdmb2VsM2pGU0li?= =?utf-8?Q?n57S1kk1fe7wXfM2dAh/SI/SM1rsmUcDirHCHZo=3D?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2559;6:gJoMh0ySdVRkMDD9zyaLdnTMrx9JtuyzM/w74JrMGDg9D/zwbUfObwM8fCQhUO6UYglyD7k4mqQVsB5KuaQxvTJ1QIixFD2GI9l+CoxB/h1oeOFr8+o1y6XrLwXy4Xwa8i9E1k4uVJai1ExrDqHaZa2NpNNn3hfFYe5gTJgOSYVJNVTTe5bR0QhzWJOaqKaQtZc+18iNAJ6EkQfEVv2766kbOtgBNsE92BC1kI33zUhM5hdeHjItSqnsr/Wf0shTolzEJVWB03NYmzTJR15S57u+2W3AVIMscCKUcfnfqv5rTBi3at/LYCvAeWh2qrkbPXBN7M3hXL2m4HURddhA8zQMrBF9J04oeQnUuWipsvYpNMzAiqs4CW2rxBHLVMeEsgIjdXWprQFn9TdOWNG43LLY0YwTK6FLcBUQ9XXvMlILfA5axsfZGCiP8UBzgT5My3dVQ3AYD64XoxtBBBR+AJiKYg1tZBDIxMsRVD4uwLdWemllvARskWamW5eOPi8upW0heTVfzYflJaPEJ+7sMw== X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2559;5:KG9TJmyKRcYAN+osJ19R637MIeXmiHIrT4jxqeeZlrpUmquJ3rNj2gIGQhiV87CHqsBtSqKPdhslb+HSc/wwQq+vxJX4FXgYVCHGnvO4KaABGKBIE6QNctV+GxrfJtrC+1WYbpGniNlB4gQvZfxhhjSfd9UoAy4kl9sR8deEx6SgsFWrKVH8/VhYGP9CPnEKOc55D9XJO9zQHFXS6Rld1uv1H4JptdpG7DeWnuY1qNwAUHU3navd2oynlj/eHwARLG4MIDHO3KdjXJAjsMOBoSXNvalQyiH0FaI7+LGKn+Ci1BbPBc1ark4mQuxLERpZuPMmpXFuUznnNb75vTXCrSKlkuRmjUoIpGox8BB+jZIImQ45/WhgJjqoi0dFO1cRlMle4MkVbzCs+Qyx9N35xycLka176L2ocmjUuQckfYnLwOea0r3BaR0jdZZxx6vmBqiUQ7YrfqcFJjb8mI78w9kXEzwAMfht+EhMls2sOsAXBFZOhbAJBMIirbsiwm04;24:HDUcqpQ76hgqWIZg8/K+3pq7o9DG0SOY1ZJvwOOKHHkIlOBJus2LQTrNNBql7kNGtEKAxM3OQ5YhhLGRIE9+d+Uo/182DfhKGQ8OFqxo5Eg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;VI1PR0202MB2559;7:RXu8Lj5NGzouFs/Kg8jcI2GW1par+blVcRre/mE0p/l9JgKrluSylETVq/N5y0yo4OSZ0876Abjs8vYLMEZBsjxRkL6BvvCN6j0cEZcfpl5Rv4aIT3stYEynmA6PNZBkhAWJ32bIiC5pxAwiuITniXJVK+g8Ny072KbwUpicO4GhffVCI26Zg9yps7EuIq1ynGd56jO4loD670KAClkO6mHVaGyutAfsumCN2PG9WNZw3yT853mJibFhNgFnH9sBVrMYKf2/h/Yz34cG6mTg7yLBFnchWEuzA7EjF3yUKjfPH0c8szQ29byBMmaJGwYlr2n83ZgsUY+TgbGfh0o+mA== X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2017 05:12:34.7361 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0202MB2559 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 784 Lines: 21 On 2017-06-08 19:36, Luis Oliveira wrote: > complicated to review. The work here won't bring any additional work to > backported fixes because is just style and reordering. I challenge that. If there is an old bug that existed before this patch that is fixed in the future after this patch has been applied, it might very well be hard_er_ to backport that fix to a point before this patch has been applied. So, what do you mean? > @@ -984,12 +984,12 @@ int i2c_dw_probe(struct dw_i2c_dev *dev) > } > > i2c_dw_disable_int(dev); > - r = devm_request_irq(dev->dev, dev->irq, i2c_dw_isr, irq_flags, > + ret = devm_request_irq(dev->dev, dev->irq, i2c_dw_isr, irq_flags, > dev_name(dev->dev), dev); Two extra spaces needed to align with the opening bracket. Cheers, peda