Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751715AbdFIHGE (ORCPT ); Fri, 9 Jun 2017 03:06:04 -0400 Received: from mail-io0-f193.google.com ([209.85.223.193]:35450 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751526AbdFIHGA (ORCPT ); Fri, 9 Jun 2017 03:06:00 -0400 MIME-Version: 1.0 In-Reply-To: <1496960243-196898-3-git-send-email-babu.moger@oracle.com> References: <1496960243-196898-1-git-send-email-babu.moger@oracle.com> <1496960243-196898-3-git-send-email-babu.moger@oracle.com> From: Geert Uytterhoeven Date: Fri, 9 Jun 2017 09:05:57 +0200 X-Google-Sender-Auth: MXISgXHVgDuADha_7Sm0S8Z9FAo Message-ID: Subject: Re: [PATCH 2/2] include: warn for inconsistent endian config definition To: Babu Moger Cc: Yoshinori Sato , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "James E.J. Bottomley" , Helge Deller , "David S. Miller" , Al Viro , Michael Ellerman , Peter Zijlstra , Ingo Molnar , Max Filippov , "linux-kernel@vger.kernel.org" , uclinux-h8-devel@lists.sourceforge.jp, "Linux/m68k" , openrisc@lists.librecores.org, Parisc List , sparclinux Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1383 Lines: 41 On Fri, Jun 9, 2017 at 12:17 AM, Babu Moger wrote: > Display warning if CPU_BIG_ENDIAN is not defined on big endian > architecture and also warn if it defined on little endian architectures. > > We have seen some generic code(for example code include/asm-generic/qrwlock.h) > uses CONFIG_CPU_BIG_ENDIAN to decide the endianess. That example is IMHO the least harmful, as qrwlock must be selected explicitly by the architecture. The uses in drivers/of/base.c drivers/of/fdt.c drivers/tty/serial/earlycon.c drivers/tty/serial/serial_core.c are more dangerous, and may have bitten people already. In addition, people may have worked around them in DT, so this series may actually introduce regressions. > Here is the original discussion > http://www.spinics.net/lists/devicetree/msg178101.html > > Signed-off-by: Babu Moger > Suggested-by: Arnd Bergmann Hmm, the link above refers to a mail from me? ;-) Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds