Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751780AbdFIHKX (ORCPT ); Fri, 9 Jun 2017 03:10:23 -0400 Received: from mx2.suse.de ([195.135.220.15]:59786 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751764AbdFIHKV (ORCPT ); Fri, 9 Jun 2017 03:10:21 -0400 Date: Fri, 09 Jun 2017 09:10:20 +0200 Message-ID: From: Takashi Iwai To: "Arvind Yadav" Cc: , , Subject: Re: [PATCH] ALSA: vx: vx_pcm: constify vx_pcm_playback_ops and vx_pcm_capture_ops. In-Reply-To: <7c7f41b54273dab90edf67c8fb4ce758a83929ce.1496991874.git.arvind.yadav.cs@gmail.com> References: <7c7f41b54273dab90edf67c8fb4ce758a83929ce.1496991874.git.arvind.yadav.cs@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1566 Lines: 52 On Fri, 09 Jun 2017 09:05:43 +0200, Arvind Yadav wrote: > > File size before: > text data bss dec hex filename > 7126 240 0 7366 1cc6 sound/drivers/vx/vx_pcm.o > > File size After adding 'const': > text data bss dec hex filename > 7382 0 0 7382 1cd6 sound/drivers/vx/vx_pcm.o > > Signed-off-by: Arvind Yadav If you're going to send more similar patches like this and previous one of pcsp, could you create a patchset containing all and send at once? thanks, Takashi > --- > sound/drivers/vx/vx_pcm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/drivers/vx/vx_pcm.c b/sound/drivers/vx/vx_pcm.c > index ea7b377..d318a33 100644 > --- a/sound/drivers/vx/vx_pcm.c > +++ b/sound/drivers/vx/vx_pcm.c > @@ -873,7 +873,7 @@ static int vx_pcm_prepare(struct snd_pcm_substream *subs) > /* > * operators for PCM playback > */ > -static struct snd_pcm_ops vx_pcm_playback_ops = { > +static const struct snd_pcm_ops vx_pcm_playback_ops = { > .open = vx_pcm_playback_open, > .close = vx_pcm_playback_close, > .ioctl = snd_pcm_lib_ioctl, > @@ -1095,7 +1095,7 @@ static snd_pcm_uframes_t vx_pcm_capture_pointer(struct snd_pcm_substream *subs) > /* > * operators for PCM capture > */ > -static struct snd_pcm_ops vx_pcm_capture_ops = { > +static const struct snd_pcm_ops vx_pcm_capture_ops = { > .open = vx_pcm_capture_open, > .close = vx_pcm_capture_close, > .ioctl = snd_pcm_lib_ioctl, > -- > 1.9.1 > >