Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751712AbdFIHVw (ORCPT ); Fri, 9 Jun 2017 03:21:52 -0400 Received: from mail-io0-f172.google.com ([209.85.223.172]:35185 "EHLO mail-io0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751519AbdFIHVu (ORCPT ); Fri, 9 Jun 2017 03:21:50 -0400 MIME-Version: 1.0 In-Reply-To: <63100617e55d78ab881baaa6baf44e8d74d0e816.1496388533.git.jan.kiszka@siemens.com> References: <63100617e55d78ab881baaa6baf44e8d74d0e816.1496388533.git.jan.kiszka@siemens.com> From: Linus Walleij Date: Fri, 9 Jun 2017 09:21:48 +0200 Message-ID: Subject: Re: [PATCH v5 03/11] gpio-exar/8250-exar: Fix passing in of parent PCI device To: Jan Kiszka , Greg Kroah-Hartman Cc: Alexandre Courbot , Linux Kernel Mailing List , "linux-serial@vger.kernel.org" , "linux-gpio@vger.kernel.org" , Sudip Mukherjee , Andy Shevchenko , Sascha Weisenberger Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 705 Lines: 19 On Fri, Jun 2, 2017 at 9:28 AM, Jan Kiszka wrote: > This fixes reloading of the GPIO driver for the same platform device > instance as created by the exar UART driver: First of all, the driver > sets drvdata to its own value during probing and does not restore the > original value on exit. But this won't help anyway as the core clears > drvdata after the driver left. > > Set the platform device parent instead. > > Signed-off-by: Jan Kiszka > Reviewed-by: Andy Shevchenko > Acked-by: Linus Walleij If I get Gregs ACK on this I can merge patches 2-11 through the GPIO tree. Yours, Linus Walleij