Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751738AbdFIHmb (ORCPT ); Fri, 9 Jun 2017 03:42:31 -0400 Received: from mail-it0-f47.google.com ([209.85.214.47]:36930 "EHLO mail-it0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751602AbdFIHm2 (ORCPT ); Fri, 9 Jun 2017 03:42:28 -0400 MIME-Version: 1.0 In-Reply-To: <20170601200820.22396-1-ralph.sennhauser@gmail.com> References: <20170601200820.22396-1-ralph.sennhauser@gmail.com> From: Linus Walleij Date: Fri, 9 Jun 2017 09:42:26 +0200 Message-ID: Subject: Re: [PATCH] gpio: mvebu: change compatible string for PWM support To: Ralph Sennhauser Cc: "linux-gpio@vger.kernel.org" , Thierry Reding , Alexandre Courbot , Rob Herring , Mark Rutland , Jason Cooper , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Russell King , Richard Genoud , "linux-arm-kernel@lists.infradead.org" , "linux-pwm@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 802 Lines: 21 On Thu, Jun 1, 2017 at 10:08 PM, Ralph Sennhauser wrote: > As it turns out more than just Armada 370 and XP support using GPIO > lines as PWM lines. For example the Armada 38x family has the same > hardware support. As such "marvell,armada-370-xp-gpio" for the > compatible string is a misnomer. > > Change the compatible string to "marvell,armada-370-gpio" before the > driver makes it out of the -rc stage. This also follows the practice of > using only the first device family supported as part of the name. > > Also update the documentation and comments in the code accordingly. > > Fixes: 757642f9a584 ("gpio: mvebu: Add limited PWM support") > Signed-off-by: Ralph Sennhauser Patch applied for next with the tags. Yours, Linus Walleij