Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751548AbdFIHrv (ORCPT ); Fri, 9 Jun 2017 03:47:51 -0400 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:53708 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751412AbdFIHru (ORCPT ); Fri, 9 Jun 2017 03:47:50 -0400 MIME-Version: 1.0 In-Reply-To: <20170609062216.26807-7-dannym@scratchpost.org> References: <20170609062216.26807-1-dannym@scratchpost.org> <20170609062216.26807-7-dannym@scratchpost.org> From: Chen-Yu Tsai Date: Fri, 9 Jun 2017 15:47:26 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v11 06/12] sun4i-codec: Add support for extra controls to struct sun4i_codec_quirks and use them. To: Danny Milosavljevic Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Maxime Ripard , Chen-Yu Tsai , Linux-ALSA , linux-arm-kernel , linux-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1428 Lines: 37 On Fri, Jun 9, 2017 at 2:22 PM, Danny Milosavljevic wrote: Again, why? > Signed-off-by: Danny Milosavljevic > --- > sound/soc/sunxi/sun4i-codec.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/sound/soc/sunxi/sun4i-codec.c b/sound/soc/sunxi/sun4i-codec.c > index f56a59ad..b1da14d1 100644 > --- a/sound/soc/sunxi/sun4i-codec.c > +++ b/sound/soc/sunxi/sun4i-codec.c > @@ -897,9 +897,22 @@ struct sun4i_codec_quirks { > unsigned int reg_dac_txdata; /* TX FIFO offset for DMA config */ > unsigned int reg_adc_rxdata; /* RX FIFO offset for DMA config */ > bool has_reset; > + const struct snd_kcontrol_new *controls; > + unsigned int num_controls; > }; > > +static int sun4i_codec_codec_probe(struct snd_soc_codec *scodec) > +{ > + const struct sun4i_codec_quirks *quirks; > + > + quirks = of_device_get_match_data(scodec->dev); > + return snd_soc_add_codec_controls(scodec, > + quirks->controls, > + quirks->num_controls); > +} > + > static struct snd_soc_codec_driver sun4i_codec_codec = { > + .probe = sun4i_codec_codec_probe, > .component_driver = { > .controls = sun4i_codec_controls, > .num_controls = ARRAY_SIZE(sun4i_codec_controls),