Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751642AbdFIH5v (ORCPT <rfc822;w@1wt.eu>);
        Fri, 9 Jun 2017 03:57:51 -0400
Received: from smtprelay.synopsys.com ([198.182.47.9]:40530 "EHLO
        smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751511AbdFIH5t (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 9 Jun 2017 03:57:49 -0400
Subject: Re: [PATCH v10 1/6] i2c: designware: Cleaning and comment style
 fixes.
To: Peter Rosin <peda@axentia.se>,
        Luis Oliveira <Luis.Oliveira@synopsys.com>, <wsa@the-dreams.de>,
        <robh+dt@kernel.org>, <mark.rutland@arm.com>,
        <jarkko.nikula@linux.intel.com>, <andriy.shevchenko@linux.intel.com>,
        <mika.westerberg@linux.intel.com>, <linux-i2c@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
CC: <Ramiro.Oliveira@synopsys.com>, <Joao.Pinto@synopsys.com>,
        <CARLOS.PALMINHA@synopsys.com>
References: <cover.1496942505.git.lolivei@synopsys.com>
 <4fb5f66dafc24e3213aaa8fc93fa12fecb6d6aa1.1496942505.git.lolivei@synopsys.com>
 <5bc3077b-2e4c-eb27-bca1-b7cbfc2dec01@axentia.se>
From: Luis Oliveira <Luis.Oliveira@synopsys.com>
Message-ID: <c6048839-9d16-8f71-809b-82b9ab35390b@synopsys.com>
Date: Fri, 9 Jun 2017 08:57:42 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <5bc3077b-2e4c-eb27-bca1-b7cbfc2dec01@axentia.se>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.107.25.78]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1181
Lines: 33

On 09-Jun-17 6:12, Peter Rosin wrote:
> On 2017-06-08 19:36, Luis Oliveira wrote:
>> complicated to review. The work here won't bring any additional work to
>> backported fixes because is just style and reordering.
> 
> I challenge that. If there is an old bug that existed before this patch
> that is fixed in the future after this patch has been applied, it might
> very well be hard_er_ to backport that fix to a point before this patch
> has been applied. So, what do you mean?
> 
Yes, that's true. But it will not be that hard since it's mostly style
(comments, format, return variables, misspelled words).
For my humble point of view the code looks better after this patch is applied.
So if It's more easy to read it should be more easy to fix also if needed.

>> @@ -984,12 +984,12 @@ int i2c_dw_probe(struct dw_i2c_dev *dev)
>>  	}
>>  
>>  	i2c_dw_disable_int(dev);
>> -	r = devm_request_irq(dev->dev, dev->irq, i2c_dw_isr, irq_flags,
>> +	ret = devm_request_irq(dev->dev, dev->irq, i2c_dw_isr, irq_flags,
>>  			     dev_name(dev->dev), dev);
> 
> Two extra spaces needed to align with the opening bracket.
> 
Thank you, you are right.

> Cheers,
> peda
> 

Cheers,
Luis