Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751628AbdFIIWH (ORCPT ); Fri, 9 Jun 2017 04:22:07 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:34651 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751584AbdFIIWE (ORCPT ); Fri, 9 Jun 2017 04:22:04 -0400 Subject: Re: [PATCH 1/3] arm: dts: mt2701: Add ethernet device node To: Erin Lo Cc: srv_heupstream@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Sean Wang References: <1496297324-21091-1-git-send-email-erin.lo@mediatek.com> <1496297324-21091-2-git-send-email-erin.lo@mediatek.com> From: Matthias Brugger Message-ID: Date: Fri, 9 Jun 2017 10:22:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1496297324-21091-2-git-send-email-erin.lo@mediatek.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1350 Lines: 46 On 01/06/17 08:08, Erin Lo wrote: > From: Sean Wang > > Add ethernet device node for MT2701 > > Signed-off-by: Sean Wang > Signed-off-by: Erin Lo > --- > arch/arm/boot/dts/mt2701.dtsi | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi > index 8037210..de88bd7 100644 > --- a/arch/arm/boot/dts/mt2701.dtsi > +++ b/arch/arm/boot/dts/mt2701.dtsi > @@ -420,6 +420,26 @@ > #clock-cells = <1>; > }; > > + eth: ethernet@1b100000 { > + compatible = "mediatek,mt2701-eth", "syscon"; > + reg = <0 0x1b100000 0 0x20000>; > + interrupts = , > + , > + ; > + clocks = <&topckgen CLK_TOP_ETHIF_SEL>, > + <ðsys CLK_ETHSYS_ESW>, > + <ðsys CLK_ETHSYS_GP1>, > + <ðsys CLK_ETHSYS_GP2>, > + <&apmixedsys CLK_APMIXED_TRGPLL>; > + clock-names = "ethif", "esw", "gp1", "gp2", "trgpll"; > + power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>; > + mediatek,ethsys = <ðsys>; > + mediatek,pctl = <&syscfg_pctl_a>; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; > + }; > + I'm missing the reset properties. Regards, Matthias