Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751643AbdFIIWz (ORCPT ); Fri, 9 Jun 2017 04:22:55 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:33029 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751554AbdFIIWx (ORCPT ); Fri, 9 Jun 2017 04:22:53 -0400 Message-ID: <1496996562.2343.3.camel@pengutronix.de> Subject: Re: [PATCH 3/3] arm: dts: mt2701: Add display subsystem related nodes for MT2701 From: Philipp Zabel To: Matthias Brugger Cc: Erin Lo , srv_heupstream@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, YT Shen Date: Fri, 09 Jun 2017 10:22:42 +0200 In-Reply-To: References: <1496297324-21091-1-git-send-email-erin.lo@mediatek.com> <1496297324-21091-4-git-send-email-erin.lo@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1517 Lines: 47 Hi Matthias, On Fri, 2017-06-09 at 10:14 +0200, Matthias Brugger wrote: > > On 01/06/17 08:08, Erin Lo wrote: > > From: YT Shen > > > > This patch adds the device nodes for the DISP function blocks for MT2701 > > > > Signed-off-by: YT Shen > > Signed-off-by: Erin Lo > > --- > > arch/arm/boot/dts/mt2701.dtsi | 84 +++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 84 insertions(+) > > > > diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi > > index 4f110d5..e20b65c 100644 > > --- a/arch/arm/boot/dts/mt2701.dtsi > > +++ b/arch/arm/boot/dts/mt2701.dtsi > > @@ -17,6 +17,7 @@ > > #include > > #include > > #include > > +#include > > #include "skeleton64.dtsi" > > #include "mt2701-pinfunc.h" > > > > @@ -24,6 +25,11 @@ > > compatible = "mediatek,mt2701"; > > interrupt-parent = <&sysirq>; > > > > + aliases { > > + rdma0 = &rdma0; > > + rdma1 = &rdma1; > > + }; > > + > > I know we have this alias in mt8173.dtsi, but I don't understand what > they are for. Do you know? The mtk_disp_rdma platform driver uses mtk_ddp_comp_get_id() to identify the specific RDMA instance, which calls of_alias_get_id(). The core code needs to know which RDMA is which to correctly set up the display data paths. regards Philipp