Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751678AbdFII3X (ORCPT ); Fri, 9 Jun 2017 04:29:23 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:38220 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751652AbdFII3T (ORCPT ); Fri, 9 Jun 2017 04:29:19 -0400 Date: Fri, 9 Jun 2017 10:29:11 +0200 From: Greg Kroah-Hartman To: Jan Kiszka Cc: Linus Walleij , Alexandre Courbot , Linux Kernel Mailing List , linux-serial@vger.kernel.org, linux-gpio@vger.kernel.org, Sudip Mukherjee , Andy Shevchenko , Sascha Weisenberger Subject: Re: [PATCH v5 03/11] gpio-exar/8250-exar: Fix passing in of parent PCI device Message-ID: <20170609082911.GA29675@kroah.com> References: <63100617e55d78ab881baaa6baf44e8d74d0e816.1496388533.git.jan.kiszka@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <63100617e55d78ab881baaa6baf44e8d74d0e816.1496388533.git.jan.kiszka@siemens.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 652 Lines: 14 On Fri, Jun 02, 2017 at 09:28:46AM +0200, Jan Kiszka wrote: > This fixes reloading of the GPIO driver for the same platform device > instance as created by the exar UART driver: First of all, the driver > sets drvdata to its own value during probing and does not restore the > original value on exit. But this won't help anyway as the core clears > drvdata after the driver left. > > Set the platform device parent instead. > > Signed-off-by: Jan Kiszka > Reviewed-by: Andy Shevchenko > Acked-by: Linus Walleij Acked-by: Greg Kroah-Hartman