Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751643AbdFIIhi (ORCPT ); Fri, 9 Jun 2017 04:37:38 -0400 Received: from smtprelay.synopsys.com ([198.182.47.9]:41117 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751580AbdFIIhg (ORCPT ); Fri, 9 Jun 2017 04:37:36 -0400 Subject: Re: [PATCH 1/4] drm: bridge: dw-hdmi: Export hdmi_phy_configure_dwc_hdmi_3d_tx To: Mark yao References: <1496976070-29573-1-git-send-email-mark.yao@rock-chips.com> <1496976343-30005-1-git-send-email-mark.yao@rock-chips.com> <593A1E13.70501@rock-chips.com> CC: Archit Taneja , David Airlie , Laurent Pinchart , Jose Abreu , Neil Armstrong , "Daniel Vetter" , Kieran Bingham , , From: Jose Abreu Message-ID: <054c9712-9548-dc1a-b22c-11961c1c81e4@synopsys.com> Date: Fri, 9 Jun 2017 09:37:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <593A1E13.70501@rock-chips.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.107.19.59] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2708 Lines: 76 Hi Mark, On 09-06-2017 05:03, Mark yao wrote: > Ignore this patch, Jose has a better patch to solve rk3399 hdmi > phy configure. > > Hi Jose > > Sorry for missing your patch about hdmi 2.0 vendor phy fixup: > https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.kernel.org_patch_9702229&d=DwIDaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=WHDsc6kcWAl4i96Vm5hJ_19IJiuxx_p_Rzo2g-uHDKw&m=8R_vb_WsWrT4y-nLrSn1RBR3e11-CkyKvht1NtJ2ZgM&s=ajY_TW_nm7T6pUv_I9ZZctUjTaEEDe9BnF-mnlvxEEs&e= > It works fine on rk3399/rk3288, can you resend a standard patch > to upstream? Sure. I forgot to send this earlier. I will send it today. Best regards, Jose Miguel Abreu > > Thanks > > On 2017年06月09日 10:45, Mark Yao wrote: >> So dw-hdmi vendor driver can reuse >> hdmi_phy_configure_dwc_hdmi_3d_tx >> to configure their hardware. >> >> Signed-off-by: Mark Yao >> --- >> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 ++- >> include/drm/bridge/dw_hdmi.h | 3 +++ >> 2 files changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c >> b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c >> index 4e1f54a..c1ceec7 100644 >> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c >> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c >> @@ -1097,7 +1097,7 @@ static int dw_hdmi_phy_power_on(struct >> dw_hdmi *hdmi) >> * information the DWC MHL PHY has the same register layout >> and is thus also >> * supported by this function. >> */ >> -static int hdmi_phy_configure_dwc_hdmi_3d_tx(struct dw_hdmi >> *hdmi, >> +int hdmi_phy_configure_dwc_hdmi_3d_tx(struct dw_hdmi *hdmi, >> const struct dw_hdmi_plat_data *pdata, >> unsigned long mpixelclock) >> { >> @@ -1146,6 +1146,7 @@ static int >> hdmi_phy_configure_dwc_hdmi_3d_tx(struct dw_hdmi *hdmi, >> return 0; >> } >> +EXPORT_SYMBOL_GPL(hdmi_phy_configure_dwc_hdmi_3d_tx); >> static int hdmi_phy_configure(struct dw_hdmi *hdmi) >> { >> diff --git a/include/drm/bridge/dw_hdmi.h >> b/include/drm/bridge/dw_hdmi.h >> index ed599be..7eb67e6 100644 >> --- a/include/drm/bridge/dw_hdmi.h >> +++ b/include/drm/bridge/dw_hdmi.h >> @@ -150,6 +150,9 @@ int dw_hdmi_probe(struct platform_device >> *pdev, >> int dw_hdmi_bind(struct platform_device *pdev, struct >> drm_encoder *encoder, >> const struct dw_hdmi_plat_data *plat_data); >> +int hdmi_phy_configure_dwc_hdmi_3d_tx(struct dw_hdmi *hdmi, >> + const struct dw_hdmi_plat_data *pdata, >> + unsigned long mpixelclock); >> void dw_hdmi_setup_rx_sense(struct device *dev, bool hpd, >> bool rx_sense); >> void dw_hdmi_set_sample_rate(struct dw_hdmi *hdmi, >> unsigned int rate); > >