Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751680AbdFIIiR (ORCPT ); Fri, 9 Jun 2017 04:38:17 -0400 Received: from mga02.intel.com ([134.134.136.20]:44012 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751531AbdFIIiP (ORCPT ); Fri, 9 Jun 2017 04:38:15 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,317,1493708400"; d="scan'208";a="866185302" Message-ID: <1496997489.22624.63.camel@linux.intel.com> Subject: Re: [PATCH v10 1/6] i2c: designware: Cleaning and comment style fixes. From: Andy Shevchenko To: Peter Rosin , Luis Oliveira , wsa@the-dreams.de, robh+dt@kernel.org, mark.rutland@arm.com, jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ramiro.Oliveira@synopsys.com, Joao.Pinto@synopsys.com, CARLOS.PALMINHA@synopsys.com Date: Fri, 09 Jun 2017 11:38:09 +0300 In-Reply-To: <5bc3077b-2e4c-eb27-bca1-b7cbfc2dec01@axentia.se> References: <4fb5f66dafc24e3213aaa8fc93fa12fecb6d6aa1.1496942505.git.lolivei@synopsys.com> <5bc3077b-2e4c-eb27-bca1-b7cbfc2dec01@axentia.se> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1172 Lines: 37 On Fri, 2017-06-09 at 07:12 +0200, Peter Rosin wrote: > On 2017-06-08 19:36, Luis Oliveira wrote: > > complicated to review. The work here won't bring any additional work > > to > > backported fixes because is just style and reordering. > > I challenge that. If there is an old bug that existed before this > patch > that is fixed in the future after this patch has been applied, it > might > very well be hard_er_ to backport that fix to a point before this > patch > has been applied. So, what do you mean? I asked this during review of ~v3. I don't remember what Wolfram told about it. > > > @@ -984,12 +984,12 @@ int i2c_dw_probe(struct dw_i2c_dev *dev) > >   } > >   > >   i2c_dw_disable_int(dev); > > - r = devm_request_irq(dev->dev, dev->irq, i2c_dw_isr, > > irq_flags, > > + ret = devm_request_irq(dev->dev, dev->irq, i2c_dw_isr, > > irq_flags, > >        dev_name(dev->dev), dev); > > Two extra spaces needed to align with the opening bracket. It's a bikeshedding, though it looks like v11 is needed anyway (see kbuild bot complains), thus it might be addressed as well. -- Andy Shevchenko Intel Finland Oy