Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751620AbdFIIz5 (ORCPT ); Fri, 9 Jun 2017 04:55:57 -0400 Received: from mga01.intel.com ([192.55.52.88]:50436 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751519AbdFIIzz (ORCPT ); Fri, 9 Jun 2017 04:55:55 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,317,1493708400"; d="scan'208";a="978717360" Message-ID: <1496998369.22624.68.camel@linux.intel.com> Subject: Re: [PATCH v10 5/6] i2c: designware: add SLAVE mode functions From: Andy Shevchenko To: Luis Oliveira , wsa@the-dreams.de, robh+dt@kernel.org, mark.rutland@arm.com, jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ramiro.Oliveira@synopsys.com, Joao.Pinto@synopsys.com, CARLOS.PALMINHA@synopsys.com Date: Fri, 09 Jun 2017 11:52:49 +0300 In-Reply-To: <434489944ec5de13e1ac4e8ad4ab161e22cb718c.1496942505.git.lolivei@synopsys.com> References: <434489944ec5de13e1ac4e8ad4ab161e22cb718c.1496942505.git.lolivei@synopsys.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 777 Lines: 29 On Thu, 2017-06-08 at 18:36 +0100, Luis Oliveira wrote: > - Changes in Kconfig to enable I2C_DESIGNWARE_SLAVE support > - Slave functions added to core library file > - Slave abort sources added to common source file > - New driver: i2c-designware-slave added > - Changes in the Makefile to compile the I2C_DESIGNWARE_SLAVE module >   when supported by the architecture. > > All the SLAVE flow is added but it is not enabled via platform > driver. > + } else { > + i2c_slave_event(dev->slave, I2C_SLAVE_STOP, &val); > + stat = i2c_dw_read_clear_intrbits_slave(dev); > + } > + > + //~ if (stat & DW_IC_INTR_TX_OVER) > + //~ dw_readl(dev, DW_IC_CLR_TX_OVER); What is this? > + > + return 1; > +} -- Andy Shevchenko Intel Finland Oy