Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261328AbTFIRz4 (ORCPT ); Mon, 9 Jun 2003 13:55:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261624AbTFIRz4 (ORCPT ); Mon, 9 Jun 2003 13:55:56 -0400 Received: from x35.xmailserver.org ([208.129.208.51]:37763 "EHLO x35.xmailserver.org") by vger.kernel.org with ESMTP id S261328AbTFIRzz (ORCPT ); Mon, 9 Jun 2003 13:55:55 -0400 X-AuthUser: davidel@xmailserver.org Date: Mon, 9 Jun 2003 11:07:32 -0700 (PDT) From: Davide Libenzi X-X-Sender: davide@bigblue.dev.mcafeelabs.com To: "Richard B. Johnson" cc: Kernel Mailing List Subject: Re: Coding standards. (Was: Re: [PATCH] [2.5] Non-blocking write can block) In-Reply-To: Message-ID: References: <20030604065336.A7755@infradead.org> <3EDE0E85.7090601@techsource.com> <20030607001202.GB14475@kroah.com> <3EE4B4C3.80902@techsource.com> <20030609163959.GA13811@wohnheim.fh-wedel.de> <3EE4C4CD.1050809@inet.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 882 Lines: 22 yOn Mon, 9 Jun 2003, Richard B. Johnson wrote: > Last I looked, we had a good example in the Buslogic SCSI driver. > However, just in case it's been changed, I submit herewith an > example of real code written by a "professional". You know why the code you reported is *wrong* (besides from how techincally do things) ? Mixing lower and upper case, using long variable and function names, etc... are simply a matter of personal taste and you cannot say that such code is "absolutely" wrong. The code is damn wrong because it violates about 25 sections of the project's defined CodingStyle document, that's why it is wrong. - Davide - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/