Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751768AbdFII5x (ORCPT ); Fri, 9 Jun 2017 04:57:53 -0400 Received: from mail-he1eur01on0101.outbound.protection.outlook.com ([104.47.0.101]:63695 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751600AbdFII51 (ORCPT ); Fri, 9 Jun 2017 04:57:27 -0400 Authentication-Results: synopsys.com; dkim=none (message not signed) header.d=none;synopsys.com; dmarc=none action=none header.from=axentia.se; Subject: Re: [PATCH v10 1/6] i2c: designware: Cleaning and comment style fixes. To: Andy Shevchenko , Luis Oliveira , wsa@the-dreams.de, robh+dt@kernel.org, mark.rutland@arm.com, jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ramiro.Oliveira@synopsys.com, Joao.Pinto@synopsys.com, CARLOS.PALMINHA@synopsys.com References: <4fb5f66dafc24e3213aaa8fc93fa12fecb6d6aa1.1496942505.git.lolivei@synopsys.com> <5bc3077b-2e4c-eb27-bca1-b7cbfc2dec01@axentia.se> <1496997489.22624.63.camel@linux.intel.com> From: Peter Rosin Organization: Axentia Technologies AB Message-ID: <3276089c-58f0-d7de-d21e-3eccc94f830d@axentia.se> Date: Fri, 9 Jun 2017 10:57:12 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1496997489.22624.63.camel@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [81.224.171.159] X-ClientProxiedBy: AM3PR07CA0127.eurprd07.prod.outlook.com (2603:10a6:207:8::13) To HE1PR0202MB2554.eurprd02.prod.outlook.com (2603:10a6:3:90::7) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: HE1PR0202MB2554: X-MS-Office365-Filtering-Correlation-Id: 7d346fbb-e97e-45bc-d295-08d4af158819 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075);SRVR:HE1PR0202MB2554; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0202MB2554;3:k17TcowpBYW9oU6EmGf/zgsYwsp1ORTM5SRewj6n5JS7swVL4qBHz2m0rLC3hoy8KAvfqWjFr0wKuha2a3mE1tyr2ngpyu5/XFwvOwcT4rhUjThjpeHKkI3VGt/+KR1TNGM+NTn6rqdXziKDqQIyVvVRCf/USXqH3jFEHoqdwloyxpttceDlPnVwVtYB9ozqWq2Btj5M+pBQQ5mBabdv3iLdorYunBhqSOlBB8U5QJCV/mqhEWaoBs8qqk+z9eYP0Yglz+p4sW8T5+FEU5Wd3RidDEDB+aoKI+N8IpRgUKI=;25:0gTSJGGYF+2MsGcVLNM67bf+T8TuY8bJLTgI0mS5cZMuSVk1vZn0JLDsJYeTDadGI1kikU4qSVvLLd2ebu9qTyi6FEjTKeio/td5Gy2exYalK/80E8WPYJMvYhlyn1AXAuxF1Ik76nVjJ4Ssok9u4+c/dC80/Hws4KgJySrB3LEyDfrnYCQ5scmWkTe9MqvEG5GGtp9FShJNRxxyyMJDyQ2kCiH6hdNcCNMAxVBuBeoHDQKia/ffMWgyVOuD5YUTDvPpuAWi0tPHHIoLo3ByCUXBwoqX/Eh6QjZR4iUeArW4/A5XK8JY9JmXmdEfMJBZypMM0otz8Iwr4WzmJ/8kBOUjC+p355hp6VxBwzJ77ZLdtYqUC8TLwlAd6G9/7DoRq10GwPy8qW0t0MMZA+2yogw6wnoalT59agTBkcUImevMyolfyb9WbN6bjgYCBIPW7AnuYlDdSukCRJWnRlE9S44iCwNBcf2MLsotfeataHM= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0202MB2554;31:OiURD7xYVzS3wjC69UEjev/BYt8kY04tUEpnQs2p7i2xvw12GPaEcGfZgq6dMiqCHBlbBnPJ3xqKAANExZt2MEO1WXgNF7tHd1TPwMYLVLQmzKtuLhT6/dzWsMAc9hHCGgkLRz46g2ELANxKelZm2R0lrVenaUxdXJpP8wsBnzP0OnMBI3JdPp3mXUnjDRfa1tznfH8bIFj+DyYwAYfCu1U9eqtOzsQXbdy63c8gBOKDBEewyl90UcEYP0vgR2naF+Emm8d3dP1TkHAmL1qoLQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(3002001)(10201501046)(93006095)(93001095)(6041248)(20161123564025)(20161123562025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(2016111802025)(20161123558100)(6072148)(6043046)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:HE1PR0202MB2554;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:HE1PR0202MB2554; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtIRTFQUjAyMDJNQjI1NTQ7NDpvcjBHeVR6L1V2Y3g1eTRWeXBTOTFvL2NY?= =?utf-8?B?c1NHYUdlcGU4SXpUZlBTRmZhSVVPSXUwSTFhN0RzYm52WmNvdDdzWEdDUGNj?= =?utf-8?B?T241aHI3N25tUmtpdzdiU1o3Mm4wdGJQY3JoNG9Nckw4Zld4Z2ZXdW5OVi9y?= =?utf-8?B?MGtyZWp3Nlk2TXpmL0RFZHVXNVY4NGp6ZU9KT1lHWlJOOXpkYVZxLzZ4MGJh?= =?utf-8?B?cDU1R2I3eG9OVGJhL3ExaHJCeVpVcElyeHh1MmlhOEl0RDY4cTE3REY1elhO?= =?utf-8?B?Q0NlVytrWms2THA0OGxLRDQ4emQ0K3JJMUpwdnJhazBxUnl4NHZpUXBTTWJD?= =?utf-8?B?VUJaVXlDc25hUWI2dDdDR3BQMFJ4YUhra2F3YlppNFVFa002bHd0WkpVbzlq?= =?utf-8?B?cjBtSFlSR2xtZVJhQUxORWx4VUtRcWxPN0RDT1BQR2VqdTM0ZHJPWXJZc0NG?= =?utf-8?B?dTAySU1oY1daamZlaDRpdlBKanpUV3BkNUdYQmlUOXBadUJjTHVQRDdzR3hH?= =?utf-8?B?MXliazR2QzJtOFJMaWVzSE92ZTZIMXJFaThMZXAzLzdiOUo2MmcyUldDUkE2?= =?utf-8?B?YkdzVnFPbVJsUGIwNFlCTXcrL1F3aFhHcUxoZTRvdHNWOWFlbnIyUXdNZmgv?= =?utf-8?B?eWR1TTZLd1liUVhiUzd3Mk1LNHJ6Vng1ZFJOUmdNMzJBUlZ0ZzFrdSt1cDJX?= =?utf-8?B?b1Zzc1NmZDVpNGtXM3FvbE9rQ0MvVFVjSjA0bDJQbnVKUmk1cTRJMHp0aXVv?= =?utf-8?B?M1FVUnkxL2JFNGdGdVdqNjBnNE81VFNaMHl0RHRYcmVUbFRHNGVNYzNNTkFX?= =?utf-8?B?RnYvZVFtdUplK2hlQXFFYVQrYXZMazJYMWoxSXIxUWc3ZGExV3dzU2VEODA5?= =?utf-8?B?QUluZzd1RDhNRUUxQmt3YzdUQkZ1OEdIVUk3bFhwNGZQMVZOc0tKSWV1SkNs?= =?utf-8?B?M0tpTjY5RmR5NnNscmRwY010NnlzZTZjTWpTT1pwOVNSY1J3R1ZSNkRta2lS?= =?utf-8?B?UHMrZFZFZWczWW5DMDUrbzZyVHFZRmpveEhuWFdEaWNTbExmSExCcStIcVEv?= =?utf-8?B?U3BoZ0hWYm9pakxsSldDWCsyVTF0K3J2bEZ6S3E4YmwrWUVKMktXVi94Q1dF?= =?utf-8?B?cklnbGFsM0diRkd5RDRjUDF1UU9xaEtHcysvb1dkU1pBUDE1Nm1IMWFJY2ts?= =?utf-8?B?OUJLcmNSZHBJRFk4aXQ1L0YyYVJBTThmVmVCZ3FlSVYvSkdZZjZNM0U3Q0JF?= =?utf-8?B?ZEt1K1VScytNeUFJVmhpeEhPMk5zTG9lbXRBZElMUDVCZGxtYnpYSmc4RUY4?= =?utf-8?B?SjJLNEZrVGZRL0s0aXpXRC9CL3FzK3k3SlBRNGd2SUtqajFZcHNmRlhxSUts?= =?utf-8?B?OEJSSUdIVDFJd004a1Bnak12ajUyVFFxWGQxbi8vbHVhaVZ3cGx6RitUK2RP?= =?utf-8?B?aWFvY0NhUTEvMWNROFVkQzFDUDJiR3ZOT215ZStxSmgveURSaDJKcVorck1S?= =?utf-8?B?d1A3dU1kVjdraHRVa3hSZUI2czllbWVzODRRai9YM2tKYXQ0UGFDUjM5bERT?= =?utf-8?B?NG41aVpkd3NkVGVHZGFueFdWNEc0WHVVcnQ2TDFJYUUzcjVJTlJtVlBqUkNH?= =?utf-8?Q?ZGFUcWP8U5k1A1c2QZMOD?= X-Forefront-PRVS: 03333C607F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(39410400002)(39830400002)(39450400003)(39400400002)(24454002)(377424004)(65806001)(65956001)(66066001)(36756003)(86362001)(31696002)(64126003)(74482002)(50986999)(54356999)(76176999)(230700001)(7736002)(7416002)(305945005)(77096006)(6246003)(6486002)(53936002)(47776003)(2906002)(117156002)(53546009)(25786009)(65826007)(3260700006)(4326008)(189998001)(3846002)(33646002)(93886004)(31686004)(5660300001)(42186005)(38730400002)(229853002)(8676002)(478600001)(81166006)(2950100002)(6666003)(23676002)(921003)(42262002)(1121003);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR0202MB2554;H:[192.168.0.125];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtIRTFQUjAyMDJNQjI1NTQ7MjM6YkFaSGwwTS95YjRpMGtJQ1hUM3FEdGdC?= =?utf-8?B?WWZSUEVyWmdqZU44T2JmV2Y4Y2psQUhEb0tyZ0ZaYjVoSWhKRGJ5MnQwYTdH?= =?utf-8?B?WGd2WkI4ajJxazdJa1Z3dlJYdmpySmpiNFFvMHA1MU5YMWhLMXpPTU1VRDlj?= =?utf-8?B?cnA0U0NZa3RXYWJWSzg5NEFRTVJMQUYvRGFvanRITE1nT1l3VVBGVGN1NlpN?= =?utf-8?B?bXREU3hHdG5NQjdLUkxNSkN0cDNTemhoUjMvT2IyVmI5VHBzODF3NThiaG9w?= =?utf-8?B?bGJwQmtGcEFKZjYrdjRhNHNuM3hLVHA0TzE1aHNZSWg2aEx6alptZ0s4Ung0?= =?utf-8?B?U3FQNzI4Q29FN2VuL0lXY24vR0RWUC8zY1ZSYjY5ODE5NTN4TFpaVTZVZjhT?= =?utf-8?B?bFgvSk9uT1lnb1FMUUxCRUtkM2JTeEVUOWFiRzYyQ2g0YjQ3Nm5YYXBmWWhz?= =?utf-8?B?YnFlMlFxSWZFOS9SL2hFSmNqQlc3cmZuVlpuanc3SnBMaG85bUVhaGpZVDlH?= =?utf-8?B?WFhSMDFuRTZvd0ZJRWNnaXdiZEVnWmRIdGxVejBUTGVoREFoTHo0T0ltRlhE?= =?utf-8?B?VkhIL0tvR1JSUkRYVk51aXdtWXk5bkxuZStQZjdhVnhRKzhlUVNqN1FTb3la?= =?utf-8?B?YVdRNE1TS0VYV3pJMnlDajUwRmgxT1BiV0dpYWFHT21BSGxWOTU4LzlaL0xH?= =?utf-8?B?ZWk4WUR4Um1FOGpabXVnbHd5Vkt6UWY1WnNNeUNHNGJUUFRrdUQ5SzJjNkxX?= =?utf-8?B?eWxOVE5CMjFrSHA5dWpZT3h4NSs1MFlOdHVjVm01dzFnR241c2ppOFBUY2FZ?= =?utf-8?B?Q1J0ZlNJcC9xMVRGWUNBa0JoeTJjbjVZNHNEeVZoYmhWSzVNUzRHNFhhdFlW?= =?utf-8?B?bG1leExKeFA2MjI5bmZpWmoyQ0hGNHprWUVGaVZGbDFrdnlqMlpqNXF1ZlNW?= =?utf-8?B?aWl4MVNNOFN0MlNwU0Z4dzcvKy9YZ05sUmsrR1JRT0w0TURrbUp1M0JpYVA5?= =?utf-8?B?dmhqZEFZTU41ZDYveVJDUTVyR2ZxN2RaMkFLQ3JTb0xWQWZubldsQ0RoMWhq?= =?utf-8?B?YlVCdFRiNHYxeDI0SE9Ca2pBOTRKZWFidzJxQ0JEU2JROFl4NmU1Vk5SeUpQ?= =?utf-8?B?cnZ3UlNiOTUwM2R3U3RPU1FvNXc1U3NqOTVmNkwxNi8xWFFVcmdwWGNLY24r?= =?utf-8?B?RGpvTkwxYlB0VW9iMlB4ckhkeFJMNE1XQVd0SllLUWN3RWoxZkZoTi9VeVp6?= =?utf-8?B?RTFobGdVL2h1aVhRQTNhR2NEUmtaa0wyZ3NwUzd4Q05vbUE0ZUN6TE1RUG9m?= =?utf-8?B?QnYyVFMzU1NDL2FYMk9XM1k3cndib3k1T01yVlZQRVo5WlVHSG0rRHBjN1Rx?= =?utf-8?B?UHNxNHBSMkpaSzNjSWVneDlJckYzV21Bc21sOXp2M3FKb2RtVnJ1Rk5RcWhX?= =?utf-8?B?Q0RzbWZSQjQ2WFJLRnJhUVdndVVPblNMOFAvbkJNWkc0MDlvSXN6Nk1iNHlS?= =?utf-8?B?YWRLbVhFMDllSHFvdjJlQ2h3M0dUa3A3MzN0eWhINkVoOFJpQUYvbWNMZndJ?= =?utf-8?B?SkFSZ2JuZ3JyTmhHcS9rV1NNMHJRQWV4ekhyVXdpSGN0YWtMcXpjb0hGQUVF?= =?utf-8?B?MFFWSUNuL1VJRUdXSndyOVNlNGh5RElXZDNvZk5CZkNlZEtkMkoyVW1mamg5?= =?utf-8?B?WS9mZGN5elB6U3MxWlc3dFVuWGNSbURUS2pVOTJ5dmwvbHF5QWNYTkVzckhP?= =?utf-8?Q?9AGsouJwO5X6nJBGFcz4I9Z0w1ueaQ0jRRrBAdg=3D?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0202MB2554;6:wWC53VCIk1LKyqHxds7qRVPIpbwXrIaalIHzZ+ahygDpj+0ZptMqaMhi4l+Cb8/hR4apmptL9a69jwWZIFU2u1Upqzf+mYKiBkbkqJGhFzcYn9oVQGKZkvdfeWQtccsm1KvZxX2pxDipGaV3V2bRozRoiR+tZBgXm9dS+yoqzAXyrRvk7p3pmV6L5paViTX1YNWnQDt7gafptaoQhXajMCAaNar4kldA1I9cvf5t/ij0KAMeh7TLptV9haWNxJ6HEb0O+rJsf5I0P4klyOu9iEq9c+tIs3eT9bHDWeNYSB0GYKilv9n37CLhNngtIpooOiG+9ntAg7p8QQ5ajKADFWecIWLX/7Wrh8pbgFJAdbmMVviZN2zwUmLDNryBtoBQdvAT58LCxoJtVVDCEuaihLOHJXiWDhtaNyR5zOY+LyarwuuTe5s28AfAEaNw/vmErfoGqY5PDpwOZmwfKOhbnLU9nZMd9vqn3YnITOnaJWfXiKYK+9MlA/mg+OJG60uZ9awbpA+7yPFTwH5aOo7eog== X-Microsoft-Exchange-Diagnostics: 1;HE1PR0202MB2554;5:qTmiakariXItvH3TifJzKTFGzIOvHUkuW/UtmePP5x/qLbs2ASZHeAUdq5xOncKNasJMv/UY1ZeqrBR17y711tNGUss0/TBPStjGb40Mpj5cP2G5UxC4oI6Cc4Vpf3sPmEosDiNjZ/hIjkrl70lAM4w/u2TV+9hOE053sag4DzVo9YILDlHRWVahJ6wSethJJM1XLQTz3Ai5TweTh60OT1B1X0xwsF8f77wjLk/iats8zAGBZOB8ehmzqPZr4I5Q9yAwjg7lWgwyMZycF3cknQurAT57Ddg3Tz6bskl7K3EEtbTGzBFOPVmHQWqsGf6FvoRwdcEW5G3/tEduN8pVDR+nTg4I9jZ/wjMViBVKl95h1G7JRZ6tCZKry5d/loiJsSSsm24yecIFpFN9/3WZBTwaJImpmOYoaXVV3d3ZxOxlR6YFh47HH92jwKs8p5x/lxgsw1J5UDN/RFEylK586Q/SOa6GzQpZATFLxNR/bIQC4iABhmlE78npryuKLakv;24:ZiZ1fgxwkFFOGpfiRLDCjeIlmeLgAWsLk8yOwurMQzie9jWNOoA4RYlJDFRpSPTfv5e1STvJxgvFj1PnEtvlqsvnn/qbrcHGU9U1kEWYfmQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;HE1PR0202MB2554;7:0IFUFUPJEEGc6RsRkE33lK+FmKIhE77yE3F1I+vwGojNtw5DvEBymDf+HBXDhuzjkSTdkIROs97FsElCxnFPvaQcwClVPPb7Muu+SCjf9sOreVtJKMcx69Ndkc0aiRRWqajdwalF+A2GYfW3ahaXIRVcTpwEBlEW+Rk0RWYo6ol4r9axByI/WVp0Ystl/4Payr5+cs+uzAfgcZNJfGAtl/x9s7UvUazC0I3zUc1xb2pX6yGPxgiPRKww9KgibTloZ5smU6yEbH1JLJv0IwfZCZY8zqKWwLhFoabDWAd7aBWBLusZaY0uoKEEFuJgZ2nHM/x4n7lk+4PMWM9f+JLDrg== X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2017 08:57:16.1345 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0202MB2554 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 789 Lines: 27 On 2017-06-09 10:38, Andy Shevchenko wrote: > On Fri, 2017-06-09 at 07:12 +0200, Peter Rosin wrote: >> On 2017-06-08 19:36, Luis Oliveira wrote: >>> @@ -984,12 +984,12 @@ int i2c_dw_probe(struct dw_i2c_dev *dev) >>> } >>> >>> i2c_dw_disable_int(dev); >>> - r = devm_request_irq(dev->dev, dev->irq, i2c_dw_isr, >>> irq_flags, >>> + ret = devm_request_irq(dev->dev, dev->irq, i2c_dw_isr, >>> irq_flags, >>> dev_name(dev->dev), dev); >> > >> Two extra spaces needed to align with the opening bracket. > > It's a bikeshedding, though it looks like v11 is needed anyway (see > kbuild bot complains), thus it might be addressed as well. > Bikeshedding or not, checkpatch.pl --strict notifies about the issue with: CHECK: Alignment should match open parenthesis Cheers, peda