Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751706AbdFIJA7 (ORCPT ); Fri, 9 Jun 2017 05:00:59 -0400 Received: from ozlabs.org ([103.22.144.67]:43371 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751530AbdFIJA5 (ORCPT ); Fri, 9 Jun 2017 05:00:57 -0400 From: Michael Ellerman To: Liviu Dudau , David Miller Cc: jon.mason@broadcom.com, andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com Subject: Re: [PATCH net-next] net: phy: use of_mdio_parse_addr In-Reply-To: <20170607161854.GC4389@bart.dudau.co.uk> References: <1496259810-3602-1-git-send-email-jon.mason@broadcom.com> <20170602.142251.851089443438560012.davem@davemloft.net> <20170607161854.GC4389@bart.dudau.co.uk> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Fri, 09 Jun 2017 19:00:54 +1000 Message-ID: <87o9txilh5.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1040 Lines: 28 Liviu Dudau writes: > On Fri, Jun 02, 2017 at 02:22:51PM -0400, David Miller wrote: >> From: Jon Mason >> Date: Wed, 31 May 2017 15:43:30 -0400 >> >> > use of_mdio_parse_addr() in place of an OF read of reg and a bounds >> > check (which is litterally the exact same thing that >> > of_mdio_parse_addr() does) >> > >> > Signed-off-by: Jon Mason >> >> Applied, thanks Jon. > > This makes linux-next fail the modules_install target as depmod detects 2 circular > dependencies. Reverting this patch fixes the issue. > > depmod: ERROR: Cycle detected: libphy -> of_mdio -> fixed_phy -> libphy > depmod: ERROR: Cycle detected: libphy -> of_mdio -> libphy > depmod: ERROR: Found 3 modules in dependency cycles! > make[1]: *** [/home/dliviu/devel/kernel/Makefile:1245: _modinst_post] Error 1 > > This is on an ARCH=arm build, build I doubt it makes a difference. Let me know if > you need some .config values in order to reproduce. Same happens on 32-bit powerpc. cheers