Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751805AbdFIJGo (ORCPT ); Fri, 9 Jun 2017 05:06:44 -0400 Received: from fllnx210.ext.ti.com ([198.47.19.17]:18577 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751507AbdFIJGl (ORCPT ); Fri, 9 Jun 2017 05:06:41 -0400 Subject: Re: [PATCH v8 0/3] Support for USB DRD PHY driver for NS2 To: Raviteja Garimella References: <1496918103-14948-1-git-send-email-raviteja.garimella@broadcom.com> CC: Rob Herring , Mark Rutland , Ray Jui , Scott Branden , Jon Mason , Catalin Marinas , Will Deacon , , , BCM Kernel Feedback , From: Kishon Vijay Abraham I Message-ID: <2f492d5a-9016-f965-8dc2-f669d785ba4d@ti.com> Date: Fri, 9 Jun 2017 14:36:06 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3359 Lines: 100 Hi, On Friday 09 June 2017 02:30 PM, Raviteja Garimella wrote: > Hi, > > On Fri, Jun 9, 2017 at 2:25 PM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Thursday 08 June 2017 04:05 PM, Raviteja Garimella wrote: >>> Changes in v8: >>> ============= >>> -Renamed phy shutdown routine >>> -Used devm_request_irq in stead of threaded irq >> >> That's not what I intended. Continue to use threaded irq but remove delayed work. >> > > Yes I get that. We see intermittent connection issues without delayed > work. Debounce delay matters there. All right! I'm unable to apply the series. Please rebase to linux-phy next (directory structure has changed) Thanks Kishon > > Thanks, > Ravi > >> Thanks >> Kishon >>> -Removed devm_unregister calls in probe routine >>> >>> Changes in v7: >>> ============= >>> Cleaned up unused variables in phy private data structure that's >>> missed out in v6. >>> Setting of phy mode to device/host is removed from phy power on. >>> routine. >>> >>> Changes in v6: >>> ============= >>> Removed spin locks which are not required as the references >>> to phy_ops in the same driver were removed in v5. >>> >>> Removed host/device 'notify' routines which are registered >>> using 'extcon_register_notifier'. The irq handler is sufficient >>> to deal with the change in extcon events within the same driver. >>> >>> Changes in v5: >>> ============= >>> Removed references to phy_ops in the same driver by connect_work >>> event handler to change the phy modes. >>> >>> To support dynamically changing the mode of the phy, it does >>> not require doing a phy reset/programming of PHY PLL. Changes >>> are made to the connect_work routine to just program the required >>> register bits to achieve this purpose. >>> >>> Changes in v4: >>> ============= >>> Remove references to edev->name in debug prints. >>> >>> Changes in v3: >>> ============= >>> Remove unnecessary checks for poweron as suggested in review. >>> >>> Changes in v2: >>> ============= >>> 1. Initialize file operations .owner field with THIS_MODULE. >>> 2. Remove unnecessary gpio example in DT bindings documentation. >>> This is previously acked by Rob Herring >>> >>> Introduction for PATCH v1: >>> >>> This patch adds support for USB Dual Role Device Phy for Broadcom >>> Northstar2 SoC. Apart from the new phy driver, this patchset contains >>> changes to Kconfig, Makefile, and Device tree files. >>> >>> This patchset is tested on Broadcom NS2 BCM958712K reference board. >>> >>> Repo: https://github.com/Broadcom/arm64-linux.git >>> Branch: ns2_drdphy_v8 >>> >>> Raviteja Garimella (3): >>> dt-bindings: phy: Add DT bindings documentation for NS2 USB DRD PHY >>> phy: phy-bcm-ns2-usbdrd: Broadcom USB DRD PHY driver for Northstar2 >>> arm64: dts: NS2: Add USB DRD PHY device tree node >>> >>> .../devicetree/bindings/phy/brcm,ns2-drd-phy.txt | 30 ++ >>> arch/arm64/boot/dts/broadcom/ns2.dtsi | 14 + >>> drivers/phy/Kconfig | 13 + >>> drivers/phy/Makefile | 1 + >>> drivers/phy/phy-bcm-ns2-usbdrd.c | 437 +++++++++++++++++++++ >>> 5 files changed, 495 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/phy/brcm,ns2-drd-phy.txt >>> create mode 100644 drivers/phy/phy-bcm-ns2-usbdrd.c >>>