Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751709AbdFIJJS (ORCPT ); Fri, 9 Jun 2017 05:09:18 -0400 Received: from mail-io0-f172.google.com ([209.85.223.172]:36822 "EHLO mail-io0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751823AbdFIJIc (ORCPT ); Fri, 9 Jun 2017 05:08:32 -0400 MIME-Version: 1.0 In-Reply-To: <1496415790-19164-13-git-send-email-rf@opensource.wolfsonmicro.com> References: <1496415790-19164-1-git-send-email-rf@opensource.wolfsonmicro.com> <1496415790-19164-13-git-send-email-rf@opensource.wolfsonmicro.com> From: Linus Walleij Date: Fri, 9 Jun 2017 11:08:25 +0200 Message-ID: Subject: Re: [PATCH v3 12/17] gpio: madera: Support Cirrus Logic Madera class codecs To: Richard Fitzgerald Cc: Lee Jones , Mark Brown , Alexandre Courbot , Rob Herring , Thomas Gleixner , Jason Cooper , "alsa-devel@alsa-project.org" , "open list:WOLFSON MICROELECTRONICS DRIVERS" , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1018 Lines: 29 On Fri, Jun 2, 2017 at 5:03 PM, Richard Fitzgerald wrote: > This adds support for the GPIOs on Cirrus Logic Madera class codecs. > Any pins not used for special functions (see the pinctrl driver) can be > used as general single-bit input or output lines. The number of available > GPIOs varies between codecs. > > Signed-off-by: Nariman Poushin > Signed-off-by: Richard Fitzgerald > Signed-off-by: Charles Keepax > --- > Changes since V2: > - Minor change now to use the parent MFD DT node for out DT bindings This looks good to me Acked-by: Linus Walleij I can also merge it through the GPIO tree once it is clear that the MFD portions are getting merged. > +config GPIO_MADERA > + bool "Cirrus Logic Madera class codecs" > + depends on PINCTRL_MADERA As this guards compilation until the MFD driver arrives. Yours, Linus Walleij