Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751548AbdFIJkc (ORCPT ); Fri, 9 Jun 2017 05:40:32 -0400 Received: from mail-qt0-f193.google.com ([209.85.216.193]:36360 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751519AbdFIJka (ORCPT ); Fri, 9 Jun 2017 05:40:30 -0400 MIME-Version: 1.0 In-Reply-To: <20170609043345.14561-1-jlee@suse.com> References: <20170609043345.14561-1-jlee@suse.com> From: Andy Shevchenko Date: Fri, 9 Jun 2017 12:40:29 +0300 Message-ID: Subject: Re: [PATCH v2] acpi: handle the acpi hotplug schedule error To: "Lee, Chun-Yi" Cc: "Rafael J . Wysocki" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Lee, Chun-Yi" , Len Brown Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1533 Lines: 53 On Fri, Jun 9, 2017 at 7:33 AM, Lee, Chun-Yi wrote: > Kernel should decrements the reference count of acpi device > when the scheduling of acpi hotplug work is failed, and > evaluates _OST to notify BIOS the failure. > > v2: > To simplify the code. (Andy Shevchenko) > > Cc: "Rafael J. Wysocki" > Cc: Len Brown FWIW, Reviewed-by: Andy Shevchenko > Cc: Andy Shevchenko > Signed-off-by: "Lee, Chun-Yi" > --- > drivers/acpi/bus.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c > index 34fbe02..91adb71 100644 > --- a/drivers/acpi/bus.c > +++ b/drivers/acpi/bus.c > @@ -427,12 +427,17 @@ static void acpi_bus_notify(acpi_handle handle, u32 type, void *data) > (driver->flags & ACPI_DRIVER_ALL_NOTIFY_EVENTS)) > driver->ops.notify(adev, type); > > - if (hotplug_event && ACPI_SUCCESS(acpi_hotplug_schedule(adev, type))) > - return; > + if (hotplug_event) { > + if (ACPI_SUCCESS(acpi_hotplug_schedule(adev, type))) > + return; > + goto err_put_device; > + } > > acpi_bus_put_acpi_device(adev); > return; > > + err_put_device: > + acpi_bus_put_acpi_device(adev); > err: > acpi_evaluate_ost(handle, type, ost_code, NULL); > } > -- > 2.10.2 > -- With Best Regards, Andy Shevchenko