Date: Mon, 9 Jun 2003 20:42:33 +0200
From: Pavel Machek <pavel@suse.cz>
To: Patrick Mochel <mochel@osdl.org>
Cc: Pavel Machek <pavel@suse.cz>, linux-kernel@vger.kernel.org
Subject: Re: [RFC] New system device API
Message-ID: <20030609184233.GA201@elf.ucw.cz>
References: <20030607203304.GB667@elf.ucw.cz> <Pine.LNX.4.44.0306090918200.11379-100000@cherise>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.44.0306090918200.11379-100000@cherise>
User-Agent: Mutt/1.5.3i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1144
Lines: 30

Hi!

> > System devices may be special, but they should not be so special not
> > to require u32 level.  All current system devices need to be
> > suspended last, but that's pure coincidence, I believe.
> 
> Fine. Then show me a device that needs a two-stage suspend. I'm not going 
> to add an extra method and semantics for something that isn't going to 
> currently be used by anyone.

Ouch?

You are currently adding more methods and semantics just to make
system devices separate from "normal" ones. If you keep two-stage
(actually three-stage suspend), you'll have system devices similar to
normal ones, and will have less special cases to care about.

And keyboard controller with its devices needs to be suspended
early/resumed late because both operations are likely to need
interrupts.

								Pavel
-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/