Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751577AbdFIKEj (ORCPT ); Fri, 9 Jun 2017 06:04:39 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:35006 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751519AbdFIKEh (ORCPT ); Fri, 9 Jun 2017 06:04:37 -0400 Date: Fri, 9 Jun 2017 12:04:35 +0200 From: Thomas Petazzoni To: Gregory CLEMENT Cc: Linus Walleij , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org, Chris Packham , Ralph Sennhauser Subject: Re: [PATCH] gpio: mvebu: fix regmap_update_bits usage Message-ID: <20170609120435.60191c76@free-electrons.com> In-Reply-To: <20170609100318.26450-1-gregory.clement@free-electrons.com> References: <20170609100318.26450-1-gregory.clement@free-electrons.com> Organization: Free Electrons X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 649 Lines: 25 Hello, On Fri, 9 Jun 2017 12:03:18 +0200, Gregory CLEMENT wrote: > regmap_update_bits(mvchip->regs, GPIO_IO_CONF_OFF, > - BIT(pin), 1); > + BIT(pin), BIT(pin)); > > return 0; > } > @@ -364,7 +364,7 @@ static int mvebu_gpio_direction_output(struct gpio_chip *chip, unsigned int pin, > mvebu_gpio_set(chip, pin, value); > > regmap_update_bits(mvchip->regs, GPIO_IO_CONF_OFF, > - BIT(pin), 0); > + BIT(pin), BIT(pin)); Are you sure here? We want to clear the bit, so I guess the 0 is appropriate, no? Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com