Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751710AbdFIKFo (ORCPT ); Fri, 9 Jun 2017 06:05:44 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:35078 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751624AbdFIKFm (ORCPT ); Fri, 9 Jun 2017 06:05:42 -0400 From: Gregory CLEMENT To: Thomas Petazzoni Cc: Linus Walleij , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org, Chris Packham , Ralph Sennhauser Subject: Re: [PATCH] gpio: mvebu: fix regmap_update_bits usage References: <20170609100318.26450-1-gregory.clement@free-electrons.com> <20170609120435.60191c76@free-electrons.com> Date: Fri, 09 Jun 2017 12:05:40 +0200 In-Reply-To: <20170609120435.60191c76@free-electrons.com> (Thomas Petazzoni's message of "Fri, 9 Jun 2017 12:04:35 +0200") Message-ID: <87zidho4qz.fsf@free-electrons.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 978 Lines: 42 Hi Thomas, On ven., juin 09 2017, Thomas Petazzoni wrote: > Hello, > > On Fri, 9 Jun 2017 12:03:18 +0200, Gregory CLEMENT wrote: > >> regmap_update_bits(mvchip->regs, GPIO_IO_CONF_OFF, >> - BIT(pin), 1); >> + BIT(pin), BIT(pin)); >> >> return 0; >> } >> @@ -364,7 +364,7 @@ static int mvebu_gpio_direction_output(struct gpio_chip *chip, unsigned int pin, >> mvebu_gpio_set(chip, pin, value); >> >> regmap_update_bits(mvchip->regs, GPIO_IO_CONF_OFF, >> - BIT(pin), 0); >> + BIT(pin), BIT(pin)); > > Are you sure here? We want to clear the bit, so I guess the 0 is > appropriate, no? argh! yes it was a mistake Gregory > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com