Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751623AbdFIKLt (ORCPT ); Fri, 9 Jun 2017 06:11:49 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:39283 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751605AbdFIKLr (ORCPT ); Fri, 9 Jun 2017 06:11:47 -0400 Date: Fri, 9 Jun 2017 12:11:41 +0200 From: Heiko Carstens To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Martin Schwidefsky , Julian Wiedmann , Ursula Braun , Peter Oberparleiter , Gerald Schaefer , linux-s390@vger.kernel.org Subject: Re: [PATCH 10/11] s390: drivers: convert to use DRIVER_ATTR_RO/WO References: <20170609090314.13991-1-gregkh@linuxfoundation.org> <20170609090314.13991-10-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170609090314.13991-10-gregkh@linuxfoundation.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-GCONF: 00 x-cbid: 17060910-0012-0000-0000-00000548F658 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17060910-0013-0000-0000-000018B8212F Message-Id: <20170609101141.GB3617@osiris> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-09_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706090180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1093 Lines: 25 On Fri, Jun 09, 2017 at 11:03:13AM +0200, Greg Kroah-Hartman wrote: > We are trying to get rid of DRIVER_ATTR(), and the s390 drivers' > attributes can be trivially changed to use DRIVER_ATTR_RO() and > DRIVER_ATTR_WO(). > > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Cc: Julian Wiedmann > Cc: Ursula Braun > Cc: Peter Oberparleiter > Cc: Gerald Schaefer > Cc: > Signed-off-by: Greg Kroah-Hartman > --- > drivers/s390/char/sclp.c | 12 ++++++------ > drivers/s390/char/vmlogrdr.c | 7 ++----- > drivers/s390/net/ctcm_main.c | 6 +++--- > drivers/s390/net/lcs.c | 6 +++--- > drivers/s390/net/netiucv.c | 14 ++++++-------- > drivers/s390/net/qeth_core_main.c | 6 +++--- > 6 files changed, 23 insertions(+), 28 deletions(-) I assume this will go upstream via your tree. Acked-by: Heiko Carstens