Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751658AbdFIKM2 (ORCPT ); Fri, 9 Jun 2017 06:12:28 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:35448 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751515AbdFIKM0 (ORCPT ); Fri, 9 Jun 2017 06:12:26 -0400 From: Gregory CLEMENT To: Ralph Sennhauser Cc: Thomas Petazzoni , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Walleij Subject: Re: [REGRESSION next] gpio-keys broken with commit 2233bf7a92e7 ("gpio: mvebu: switch to regmap for register access") References: <20170609085038.4af4f038@gmail.com> Date: Fri, 09 Jun 2017 12:12:24 +0200 In-Reply-To: <20170609085038.4af4f038@gmail.com> (Ralph Sennhauser's message of "Fri, 9 Jun 2017 08:50:38 +0200") Message-ID: <87vao5o4fr.fsf@free-electrons.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 887 Lines: 34 Hi Ralph, On ven., juin 09 2017, Ralph Sennhauser wrote: > Hi Thomas, > > Commit 2233bf7a92e7 ("gpio: mvebu: switch to regmap for register > access") in next-20170607 breaks gpio-keys on an armada-385 (Linksys > WRT3200ACM), noticed due to missing /dev/input/event0 and the below > dmesg output. > > # dmesg -l 0,1,2,3 > [ 2.421130] genirq: Setting trigger mode 3 for irq 49 failed (mvebu_gpio_irq_set_type+0x0/0x168) > [ 2.429953] gpio-keys gpio-keys: Unable to claim irq 49; error -22 > > > After reverting the offending commit all works again. I found the bug and I've just sent a fix for it (use the v2 as the first version was wrong). Thanks for the report, Gregory > > Ralph -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com