Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751618AbdFIKrc (ORCPT ); Fri, 9 Jun 2017 06:47:32 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:60524 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751536AbdFIKra (ORCPT ); Fri, 9 Jun 2017 06:47:30 -0400 From: Arnd Bergmann To: qla2xxx-upstream@qlogic.com, "James E.J. Bottomley" , "Martin K. Petersen" Cc: Arnd Bergmann , Himanshu Madhani , Quinn Tran , Nicholas Bellinger , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] scsi: qla2xxx: fix printk format string warning on 32-bit Date: Fri, 9 Jun 2017 12:46:54 +0200 Message-Id: <20170609104711.3471894-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:8+4SGPUrE2FP9KKLOIqA7Qi9zudBTfVO7FDVYg01MB0tb7idzKd sTy9qG0Iham73mVzdnQwFczkKjyH+EvW5nyivWtjLvHuqoBt8QkWOj6tY7JGhcgZFdiLHXc 7HIfRikirQav4XcAWwOp2X4zg9Lx235yF8CLfT9+g5rXQXHRBIkx20mK8gh6aGfxnHYOkvg mzl9CbUHv4aaTbzYgAx5A== X-UI-Out-Filterresults: notjunk:1;V01:K0:ymARpRY39RY=:Lig4rnwEQ2jfs0bZkmmmDs fyCm1L0tak5x8DuJP5cuutawA7tlKN1Pc9ddkpfBW9UQyw48GlGIwPLuAOPASxAqyKhMSSvgS +qBVw4SOPUnFOFhQ6ADoDXSGk+2T/sustQL6WxSvHNWkbNUrQvw0fY9LL094RdEzZY/PWdxsP XAe0mJFr7J/iQulc7sCacjgbZ5555rsLs8vfCB1I3Gs7cwS/JZnzqLFGx0Nr0jsuqUxiHH/bl g2gqWcpIWDNUOhpG6LkzAbdNfhs8wAoHx7IgeQiSrZDmNVGjdj8qVa6MmIYuF8ZOr2IZ32Lh7 095nULnRIx9awtiN53tm6tQGTt+4fUVNYAl63wtRvW40kUaVVUbfaBRxrXnCmKaxGPUrkmrg4 lgLAwVpZRdtly1SB3x1DYP1AOr8SDGDTFBCqSuSWpHZoGv8MTWlN1cO1QAIuw+FsesnQHwC5r cWoU6sLU2QE/AP5HKdBYruEErNKpgZFb1RM8wSwNgL4S1o03FWgWkYfpPo0A4yfgUUmWMB2qw woxbvXgthrPK/6P4JmXQG16feQqkPEy2sGMzNiSqX0P3akiLBR4wDAc1mRIMJVwssoXVRqypo gH2Y9V55Z+emKtM1LTDY6yI/KxrWJBw5I30X9qrY1WIYhboEmRLxBXz9llzOIQ8pptbAEa8TO jyibSMTeQ5ZCzrizhqngwtJOFVl8OI8VvC7YoDtTkQ5RPcRXdW6Vn7ZBt2xAcARrAOLM= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1822 Lines: 40 On 32-bit architectures, we using %lx to print a size_t causes a harmless warning: qla2xxx/qla_init.c: In function 'qla24xx_load_risc_flash': qla2xxx/qla_init.c:6407:7: error: format '%lx' expects argument of type 'long unsigned int', but argument 5 has type 'unsigned int' [-Werror=format=] qla2xxx/qla_init.c: In function 'qla24xx_load_risc_blob': qla2xxx/qla_init.c:6709:7: error: format '%lx' expects argument of type 'long unsigned int', but argument 5 has type 'unsigned int' [-Werror=format=] The correct format string is %zx. Fixes: 0f110b54d157 ("scsi: qla2xxx: Retain loop test for fwdump length exceeding buffer length") Signed-off-by: Arnd Bergmann --- drivers/scsi/qla2xxx/qla_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index 436968ad4484..730e7fe4344a 100644 --- a/drivers/scsi/qla2xxx/qla_init.c +++ b/drivers/scsi/qla2xxx/qla_init.c @@ -6404,7 +6404,7 @@ qla24xx_load_risc_flash(scsi_qla_host_t *vha, uint32_t *srisc_addr, "-> template size %x bytes\n", dlen); if (dlen > risc_size * sizeof(*dcode)) { ql_log(ql_log_warn, vha, 0x0167, - "Failed fwdump template exceeds array by %lx bytes\n", + "Failed fwdump template exceeds array by %zx bytes\n", (size_t)(dlen - risc_size * sizeof(*dcode))); goto default_template; } @@ -6706,7 +6706,7 @@ qla24xx_load_risc_blob(scsi_qla_host_t *vha, uint32_t *srisc_addr) "-> template size %x bytes\n", dlen); if (dlen > risc_size * sizeof(*fwcode)) { ql_log(ql_log_warn, vha, 0x0177, - "Failed fwdump template exceeds array by %lx bytes\n", + "Failed fwdump template exceeds array by %zx bytes\n", (size_t)(dlen - risc_size * sizeof(*fwcode))); goto default_template; } -- 2.9.0