Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751618AbdFILB3 (ORCPT ); Fri, 9 Jun 2017 07:01:29 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:37083 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751524AbdFILB1 (ORCPT ); Fri, 9 Jun 2017 07:01:27 -0400 Date: Fri, 9 Jun 2017 13:01:25 +0200 From: Thomas Petazzoni To: Gregory CLEMENT Cc: Linus Walleij , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org, Chris Packham , Ralph Sennhauser Subject: Re: [PATCH v2] gpio: mvebu: fix regmap_update_bits usage Message-ID: <20170609130125.43b8258f@free-electrons.com> In-Reply-To: <20170609100917.26660-1-gregory.clement@free-electrons.com> References: <20170609100917.26660-1-gregory.clement@free-electrons.com> Organization: Free Electrons X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 740 Lines: 24 Hello, On Fri, 9 Jun 2017 12:09:17 +0200, Gregory CLEMENT wrote: > In some place in the driver regmap_update_bits was misused. Indeed the > last argument is not the value of the bit (or group of bits) itself but > the mask value inside the register. > > So when setting the bit N, then the value must be BIT(N) and not 1. > > CC: Chris Packham > CC: Ralph Sennhauser > Signed-off-by: Gregory CLEMENT Reviewed-by: Thomas Petazzoni Thanks for fixing this so quickly! Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com