Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751591AbdFILZz (ORCPT ); Fri, 9 Jun 2017 07:25:55 -0400 Received: from mail.santannapisa.it ([193.205.80.98]:21519 "EHLO mail.santannapisa.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751541AbdFILZy (ORCPT ); Fri, 9 Jun 2017 07:25:54 -0400 Date: Fri, 9 Jun 2017 13:25:47 +0200 From: Luca Abeni To: Colin King Cc: Ingo Molnar , Peter Zijlstra , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH][-next] sched/deadline: make new function grub_reclaim static Message-ID: <20170609132547.42891867@luca> In-Reply-To: <20170609110851.16822-1-colin.king@canonical.com> References: <20170609110851.16822-1-colin.king@canonical.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1218 Lines: 37 On Fri, 9 Jun 2017 12:08:51 +0100 Colin King wrote: > From: Colin Ian King > > Make function grub_reclaim static to clean up the following sparse > warning: > > "warning: symbol 'grub_reclaim' was not declared. Should it be static?" > > Signed-off-by: Colin Ian King > --- > kernel/sched/deadline.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c > index e12f85975857..2ddb4e6d820f 100644 > --- a/kernel/sched/deadline.c > +++ b/kernel/sched/deadline.c > @@ -1052,7 +1052,7 @@ extern bool sched_rt_bandwidth_account(struct rt_rq *rt_rq); > * should be larger than 2^(64 - 20 - 8), which is more than 64 seconds. > * So, overflow is not an issue here. > */ > -u64 grub_reclaim(u64 delta, struct rq *rq, struct sched_dl_entity *dl_se) > +static u64 grub_reclaim(u64 delta, struct rq *rq, struct sched_dl_entity *dl_se) > { > u64 u_inact = rq->dl.this_bw - rq->dl.running_bw; /* Utot - Uact */ > u64 u_act; Looks good; thanks for fixing this (and sorry for introducing the warning). Acked-by: Luca Abeni Luca