Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751720AbdFIMVu (ORCPT ); Fri, 9 Jun 2017 08:21:50 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:36748 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751572AbdFIMVs (ORCPT ); Fri, 9 Jun 2017 08:21:48 -0400 Date: Fri, 9 Jun 2017 14:21:44 +0200 From: Ralph Sennhauser To: Gregory CLEMENT Cc: Linus Walleij , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, Chris Packham Subject: Re: [PATCH v2] gpio: mvebu: fix regmap_update_bits usage Message-ID: <20170609142144.5f6c916b@gmail.com> In-Reply-To: <20170609100917.26660-1-gregory.clement@free-electrons.com> References: <20170609100917.26660-1-gregory.clement@free-electrons.com> Organization: none X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 645 Lines: 20 On Fri, 9 Jun 2017 12:09:17 +0200 Gregory CLEMENT wrote: > In some place in the driver regmap_update_bits was misused. Indeed the > last argument is not the value of the bit (or group of bits) itself > but the mask value inside the register. > > So when setting the bit N, then the value must be BIT(N) and not 1. > > CC: Chris Packham > CC: Ralph Sennhauser > Signed-off-by: Gregory CLEMENT > --- Hi Gregory, Tested-by: Ralph Sennhauser Thanks for the prompt fix Ralph