Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751734AbdFINZs (ORCPT ); Fri, 9 Jun 2017 09:25:48 -0400 Received: from www62.your-server.de ([213.133.104.62]:36511 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751542AbdFINZq (ORCPT ); Fri, 9 Jun 2017 09:25:46 -0400 Message-ID: <593AA1D0.3030100@iogearbox.net> Date: Fri, 09 Jun 2017 15:25:36 +0200 From: Daniel Borkmann User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Alexei Starovoitov , Edward Cree CC: davem@davemloft.net, Alexei Starovoitov , netdev@vger.kernel.org, iovisor-dev , LKML Subject: Re: [RFC PATCH net-next 2/5] bpf/verifier: rework value tracking References: <92db9689-af6a-e172-ba57-195e588f9cc0@solarflare.com> <20170608023239.lsqijtfcg5fadpai@ast-mbp> <81a661cc-a37c-336b-c10f-1fd4b301ca54@solarflare.com> <20170608164553.y2jvdbmsqqdc7cqt@ast-mbp.dhcp.thefacebook.com> In-Reply-To: <20170608164553.y2jvdbmsqqdc7cqt@ast-mbp.dhcp.thefacebook.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 961 Lines: 22 On 06/08/2017 06:45 PM, Alexei Starovoitov wrote: [...] > I think Daniel will be happy to test your next rev of the patches. > I'll test them as well. > At least 'insn_processed' from C code in tools/testing/selftests/bpf/ > is a good estimate of how these changes affect pruning. Without having looked more deeply (yet), I ran couple of tests with the cilium test suite to track complexity. Overall programs load with the set applied, worst case increase I've seen for some of the current progs was by ~80% from ~33k to ~60k insns. Will still go over the code for an initial review either today or tomorrow. > btw, I'm working on bpf_call support and also refactoring verifier > quite a bit, but my stuff is far from ready and I'll wait for > your rewrite to land first. > One of the things I'm working on is trying to get rid of state pruning > heuristics and use register+stack liveness information instead. > It's all experimental so far. Thanks, Daniel