Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751676AbdFINoT (ORCPT ); Fri, 9 Jun 2017 09:44:19 -0400 Received: from mail-dm3nam03on0043.outbound.protection.outlook.com ([104.47.41.43]:55744 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751545AbdFINoN (ORCPT ); Fri, 9 Jun 2017 09:44:13 -0400 From: "Mintz, Yuval" To: Arnd Bergmann CC: "David S. Miller" , "Chopra, Manish" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH net-next] qed: add qed_int_sb_init() stub function Thread-Topic: [PATCH net-next] qed: add qed_int_sb_init() stub function Thread-Index: AQHS4QxzCR8w/KpU0EilyjMc05cYkKIcinrg Date: Fri, 9 Jun 2017 13:44:01 +0000 Message-ID: References: <20170609103744.3239316-1-arnd@arndb.de> In-Reply-To: <20170609103744.3239316-1-arnd@arndb.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: arndb.de; dkim=none (message not signed) header.d=none;arndb.de; dmarc=none action=none header.from=cavium.com; x-originating-ip: [31.168.140.228] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM2PR0701MB1424;7:EgQb5CsJhtdqyp2I6JqqBqsaD37YRor1CohaX4R27yI5awxJk35IKIP7hf8zwr0Os9c9XUbf4qFhh/zrYUJn6SgSLZRbaWYg/4mctVxMzwayD/c2zeHQLxiIWM6iq8OiHAsjZkGu0tOHeFrOAVSmVtAqp5YgQBOOSaVZE1VFCI8Yt3GCjq5h34EdeLq0A932rT/hHrAPFmYO/jQNZbG4dJoKmV0hyyE8wbSAwGmXdsofJL7zCqz6Na3wI4lv51h9wyYO5ihdUHxp752NCoQY3EV4H6zgj7s0FQi7xRmDHAU8Ti63p6PKly6A5Y0AsSAQiYc3y7UVcmK3o/g/ThOW8g== x-forefront-antispam-report: SFV:SKI;SCL:-1SFV:NSPM;SFS:(10009020)(979002)(6009001)(39840400002)(39450400003)(39850400002)(39400400002)(39410400002)(33656002)(229853002)(122556002)(72206003)(50986999)(6506006)(76176999)(9686003)(54356999)(55016002)(14454004)(54906002)(99286003)(8936002)(8676002)(81166006)(6916009)(2950100002)(5660300001)(189998001)(7696004)(3280700002)(102836003)(3846002)(74316002)(6116002)(4326008)(2900100001)(3660700001)(7736002)(305945005)(2906002)(110136004)(77096006)(25786009)(86362001)(6436002)(38730400002)(6246003)(478600001)(66066001)(53936002)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM2PR0701MB1424;H:BLUPR0701MB2004.namprd07.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; x-ms-traffictypediagnostic: DM2PR0701MB1424: x-ms-office365-filtering-correlation-id: fcf87f1c-f403-4bf4-463e-08d4af3d963d x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(201703131423075)(201703031133081);SRVR:DM2PR0701MB1424; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6041248)(20161123562025)(20161123560025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DM2PR0701MB1424;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DM2PR0701MB1424; x-forefront-prvs: 03333C607F spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jun 2017 13:44:01.3296 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0701MB1424 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v59DiaZG018265 Content-Length: 640 Lines: 15 > When CONFIG_QED_SRIOV is disabled, we get a build error: > > drivers/net/ethernet/qlogic/qed/qed_int.c: In function 'qed_int_sb_init': > drivers/net/ethernet/qlogic/qed/qed_int.c:1499:4: error: implicit declaration > of function 'qed_vf_set_sb_info'; did you mean 'qed_mcp_get_resc_info'? [- > Werror=implicit-function-declaration] > > All the other declarations have a 'static inline' stub as an alternative here, so > this adds one more for qed_int_sb_init. > > Fixes: 50a207147fce ("qed: Hold a single array for SBs") > Signed-off-by: Arnd Bergmann Missed it. Thanks. Acked-by: Yuval Mintz