Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751760AbdFIOTg (ORCPT ); Fri, 9 Jun 2017 10:19:36 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:35907 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751538AbdFIOTd (ORCPT ); Fri, 9 Jun 2017 10:19:33 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=fb.com; Subject: Re: [PATCH] loop: fix error handling regression To: Arnd Bergmann CC: Ming Lei , Hannes Reinecke , Omar Sandoval , References: <20170609101938.2807152-1-arnd@arndb.de> From: Jens Axboe Message-ID: Date: Fri, 9 Jun 2017 08:19:19 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170609101938.2807152-1-arnd@arndb.de> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: BN6PR06CA0017.namprd06.prod.outlook.com (10.175.123.155) To CY4PR15MB1189.namprd15.prod.outlook.com (10.172.177.11) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PR15MB1189: X-MS-Office365-Filtering-Correlation-Id: 350d1785-5c28-462e-12b2-08d4af4287de X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:CY4PR15MB1189; X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1189;3:d1uv1RLuCINURsU6PMNPv0NblHNTR50ZMmmHCkhPsuATB+jNc0Oc3FbSlNzBbVjUWY0VD3SMNDXy3VQUmdUCnw2jO4SWq1u5wEJxA6wH9vMKaswWh1mtO3soT5Cz9zd+B0cdMsAyQJnTdyXdMZ0x4K13dq9GwQ097v6Omf7PXHJqIYjx6XXTXja5HvD9/vu0bBNih8ixz9r0FJbNYded1jqDQYgU8ZWUYz1abeNOAa73+eQuUEXODwIe9RA+Di8KriDcnT/Lfuw0aE7mcvx0zEGlo5K1AqvXJKrVawokOgYvq9jRIblhBQRhXC5xX+fzV8O4yoo76iv9ei5e7c5fBg==;25:tkwy+v7gb2z7opNRwKrf4Pg0LX++DQ26TFAQHiDrkoW0RpSTZtIGdrQzWDAKIads9z6jWsfBC4jKYvoUDgwi0l5GixYQlVGOUcZNgX5pmD87vhS9z1IhTaybBRbbWjVca53q8Av75M1L2VOR30O1K6dNkpq0NIT/mpnwrRBQpdOu3t9u22+clyzOay9QlAf1MeI6pARrgfl+nBVtKocG1F+eL82L9qthrVk6MuDqTno5GTO6O9CfrUdpaV3nV5L3fx+W6+PF3cMTdh6T0xZIg1pqgFE6Emm7o1BUmumWA2wF5b6KDH3akgGCnCUWjqwSBOo7GBwLljWLcKalP1vXW9MkdObT08Mu8mX/ojezZs7e25hGTEUsspeHGJ4NBBW/McBxtkNzlvaplZ83VYTcZG5xrG4bEO3nmmY7sIs+/2nHidmxjO3FK50vzP6wtBoVd8TIqTJvoK5mknJiVuezOV8mvLUHNwawng4v1E9hUxU= X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1189;31:++mz4zlOfLecRoM00frWu2bPCQlYLF6D5+AFlMkzIMtGItV1d1ZcYuUp3+TJGIdVLJF7RpsyYHuupzVmL753Oyy2OqvyeTwfC5GUYbqH3boXyfbE1Wsh9pd1McegNMZIOUznt6EHKLG761NLvsLnkj2+lRpV8ztXApZaeybz6PcZm5OyDuPRSGtXD1Pg/K83gPCxofxm/FFjjjTCklxog8xXGcC4pJfi50FVaUJHFrs=;20:o+9W8uQUFu434vDB1+9A1NWhmn+XxVq8dYtJ8px2nEtgqP1qLQEeiY5Azxvy+oXrFEs8vSIgKhQd+NG8qVys5Ljw487dRm9dAjMXb0rkqiKfb6drckv2OalNH9LSLRHPsN1J1kQaVkCCrlboxPGtHRQwNi7k/HzMGQObZvwg68O8XtXMfsoSiqS/MmnAd82lV1b3MfbkKiFTaYzjeIBvCf6rxzA7AE6m0M2yf8/w66I2C2FCPqfBv+XOeGAMftkgUbOMhgIYTVKhWKOm422RD1Ks74ZEZE4oUmr6Pzi15RxSNCXTiVV3hQg9CigrPNToadTbuSzHhJZa3eyV7TMbusXARsVZZwkZeh0GEmge7KIiyhfGBlUlgwABF2wVdiO6zG1tFTi4OdPv1ztCkbjpTZDsrkrqypZkBLHYwmljSHAgGFaKsOXQANvcPtMzPXAPoG7uLX3FNdSVHu+GNg1wBwq59m7dddKJi94ZWevVgSYpryUcUMKjxtKu0LHkBbOr X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6041248)(20161123555025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123560025)(20161123564025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY4PR15MB1189;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY4PR15MB1189; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjE1TUIxMTg5OzQ6cWkyYUtyS0RaWTZWMERick41d3BQbFVGQ1RI?= =?utf-8?B?UlVpSE91RkNCZmRvbjF4bWE3M2ZmbmY1dDhaQnV3bWxsOFRjcVZYYmZhLzdM?= =?utf-8?B?WUVseDFPVkJmUlhKOVpBZGgyWEJwZ1BOc0t4bVBJR1pqMm85Z1dQSUVid2V3?= =?utf-8?B?ZGVQTjRpelRCQWtBSng3U2lVMkN0YU5JQWRjcEpxU3Y5RU1MQlFVOFFZNlZ5?= =?utf-8?B?NjVid1hMOWdielg1WXA4cWRKcnNNYXJJSDhvK3NmRmY0bERyeHplRkpBOUlk?= =?utf-8?B?c0ZER1JxdEJycktrTUFtSXl3MzUzbitlclVQcE9RREREUXZDQnlWL05ZM1My?= =?utf-8?B?dGhuN2NQaC93VzBUNjQ2aXljSVZVZTZzTnRDRVFZWW5LK3R2eXZJdmdESGpH?= =?utf-8?B?cUVKZDhpNlIwcmt1bHlZUVlxVjdNN3k4MlgyNW5ROENUWk1rUnRIb2NMM2RJ?= =?utf-8?B?c3VXMUVTN0txOGJSSkVFT0xWc0VlMzFVbG9JYWVITnlRODBNTlpjSkdkcGRD?= =?utf-8?B?MFlCR1ZkamdYMDJ4cUJ3ZnhPR3B3c09KTWtLN0FGTzczdlZ2ZDJlRkJhOFpU?= =?utf-8?B?cnR4OTFJbzBCSFk1bXhWVlBGSkMyYlZJYytXazhlNXJmWGRtN2VyeVYvVVo3?= =?utf-8?B?dzlrYS9iTkN3OGVLTnpNTjBhNHd0TXNSWU5qN3YrUnFNbkw4a0xFZzM0SlFu?= =?utf-8?B?Q091WEVrdHlDWDI1Z3psQjJtQXQrTTNrV0s4Z2VXeC9qYWlXWkVJL3lWcFBv?= =?utf-8?B?SFpoVWxUR0pBMVZRSmpXZW55Rk1iV0RUSThKYkpVOE9VVVFpdEhQTlVSNDNR?= =?utf-8?B?VDRIVEk2S01rV296M2NjUjNUWXpGTndvZ1VEYnVDL0hJb0ltUEU5TUJjREdZ?= =?utf-8?B?MXJqMUpiNTl4TTZnOE14WXcxdFVxdWxyRktKZDRkY3V5L3dFQnhHWXBKM3NB?= =?utf-8?B?a2U5Qjh1SkVkbHpIR2UzUnNzQzM2UVFqN0ozZEs5ck9qaFprcGlzRnBnQXBu?= =?utf-8?B?L21INmZTeE1mWHM1MTg0Yko0YkR3ODAwMDQzYVY1aS9uR0ZIcXZSRFpsSnZI?= =?utf-8?B?Mm5FU29mT1dScUorQkZsaWdpT1JTcHc2ZVJNb0pyaGcyeUx4UExZZU9BWjY0?= =?utf-8?B?SzI1M1JWcEhKR3NhdFkvWDRlWGl1aU1SVEJwRGpzSEtma1ZSd1VYQUdjNUU5?= =?utf-8?B?MkM2N25kRFd4VWgzd1NXL2xqRXplOFc2QmEwQU0zUUpJVHZTUmljM3lmbGhO?= =?utf-8?B?UFIreS94MDd0TU94amsvVm4vNWx1Vyt4MlNYS2xpMWxyanJBVnlpZjhhNkE1?= =?utf-8?B?ek8xZnB3Umplc2hhUWxGcWdIVW5Va2FZdnlZYTFlUkhiZGJaYmY5NE1ERWs1?= =?utf-8?B?S1YrUTdTV25kRGpKZ0d5MklJeHQ2dE9LWWxvMzdaeDM0SUloVEhORVVabGty?= =?utf-8?B?UzFYTHd3WnBGVmUrSFdBeXQ3TGl0ZFpyVEdULzlzZFNrUHd1V2FGajdHSlQ5?= =?utf-8?Q?cJeStXi4xL4oXyXqq9ITjBAUiWbtDTwUlktpKyA+Yu8FP?= X-Forefront-PRVS: 03333C607F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(39840400002)(39850400002)(39400400002)(39450400003)(39410400002)(24454002)(377454003)(4326008)(23676002)(86362001)(50986999)(2950100002)(36756003)(117156002)(64126003)(33646002)(25786009)(6246003)(2906002)(38730400002)(53546009)(189998001)(6916009)(76176999)(110136004)(6666003)(31696002)(54356999)(229853002)(77096006)(65826007)(5660300001)(6486002)(478600001)(42186005)(7736002)(305945005)(81166006)(8676002)(31686004)(47776003)(54906002)(3846002)(53936002)(65956001)(66066001)(65806001)(90366009)(230700001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR15MB1189;H:[192.168.1.154];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjE1TUIxMTg5OzIzOjJPdXFuY0ttVFFtaU5iWXdkUWdlNVZhYnpv?= =?utf-8?B?aXhWcXUzWU1DTGRWWEI2NnZRZTBkRGZWR3FhZVJVLytCZHpxSXBSa2ZkQ3dr?= =?utf-8?B?NFRKdzNmQU5qejFERXJrNGtFRXlxbFVLanpvZHZMYTlLVk5qRFl1N3J2bjlN?= =?utf-8?B?U2swTW5lUVlwaFo2aHJFbG84aG5NU0tMbkx2RFNVU21TaStGVExpRDlJZ3JB?= =?utf-8?B?YVlCOTB1WExhdTl5eTg0Rk1FOGw4Mng2VzBpVzh1RXhheDZHSWczTnBGMG5B?= =?utf-8?B?YzVxM29RUkhxcHB2cG4vTE5yQmtNK3pBeE90TTdTaUxKUnI2b2Z5Q1drUnZh?= =?utf-8?B?cnZ3VU5aLysyRFhneUFUa2F2NVIwYURldURtZjFhQ3FRUHQ2c2wwVDhvY3Fl?= =?utf-8?B?ZGlteU5MKzRuQ1RvWG0xWmlPKzVRdUhud0xFYjhhMzQwZFBDK01WUmR0aytq?= =?utf-8?B?MmdKa29heFpub2lnTldoMzA3d2NGMUdGRCtTZStmbzBvZnNXS3Q1ZDh0UE91?= =?utf-8?B?aGZjR3JuaXpKTnVQOWxLMEhqdHEvYWl5Q0RLeFRVQzZMUlR3ZGFBRnRLY0FM?= =?utf-8?B?bUFTcG5DN3M4UXJtMnd3MWVWNlppMFp5d2dhZ2xaTHoyK2pET3krV1ZrdlRI?= =?utf-8?B?eXhZdWhFT0xBWHF1VVpxVXkyN0NQTkhwekpDWEM2NTBmSVdsSnc4c2lhYzU1?= =?utf-8?B?UzNkYlBKY3FlWDZDczlWMWVrUHhVbDNzcEJ6bXp4WXFZUmVGdUtsZWlIYkNG?= =?utf-8?B?T1cxQWkvNjJWd1FpYkdhZXFNdVAvbEZoQUVMTjJ2b1RDd3NmdjhOWUw0ckxy?= =?utf-8?B?anBaQlF3T0NpVGZvWk0zcWFjWEFqSndUMVZWc0ZWTTNjdTN1K25zMVBFUHFx?= =?utf-8?B?MDBIRW1yTDdSR01iQWVtZzQ1WUVOQlZ0L25OVnB5OHpMaTBXdzZna3A0amxL?= =?utf-8?B?USsvK29LSzBPK3JUN2pEbzhmcGl2eVA0ZHViYmNLQStHcGc2QzVWUVB5cVN2?= =?utf-8?B?SHM5M090eEliMVNBMzhJWXBTSGtuSlRlZmVsTk5NNU9tZ2ttQmVVUFI2YjNs?= =?utf-8?B?QVovcmlnaW1GbzRDamRKdkhiSlVYNlRURWhaZHRqeVBWOU1SNTJyc3lxeDlY?= =?utf-8?B?SVpNMmJBaUR0bERGYmMyUkJVVDBFU29ka0VqeFZsT1ZFbFpDUDF6b08zcGR1?= =?utf-8?B?S1RVTm1oQmlJbWVIUjBRSXYzZ3Vib3hNTDEwTyt2cGZGZk5nbVBTY3QvNTVW?= =?utf-8?B?eWIxN244SzZzTWFIamJvTmcxdk91RkZYVXFHTU5kbVVJK3BQdms4eCtTajVi?= =?utf-8?B?RmdRZEZyeVFWN3FlZGxHNGlySHJRcGVaTjJ5RmttWjNnSGViY1JrZDhVUmc2?= =?utf-8?B?SThMeWlFNFZVcWhwcGJVS3dpN2RvQXBnOVhlblJsdmgxbDlpSEFDRFdmTEFV?= =?utf-8?B?UGk1eC9YVlYyZHpMRzA1UGVuVkxmdFl1T3d1M2pPb1RLdjVTTkx1Y3J4REEy?= =?utf-8?B?a0JGNDdXRmZyT0htSUEwVEdKK0g2OHZzOFMwZmVoOUxUY2pDNGpab2h0TFUy?= =?utf-8?B?VnJLR0VaeElMNjRON3U1ZEFPNnprVElQZGw2b2IxTm5tUG9YSHIxMy9oVjY5?= =?utf-8?B?WGp3K0svS1lrNlBDQkozNjBVcVdKRDBLSS84MjRUVVhlSk5Ta2pXYzdUc3VS?= =?utf-8?Q?Md5+kh7o83uu9kX13lZ5UngdeiceLDmf6bBomMS?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1189;6:nRZCSGmVohvoX1z7fF2UPdOkFqWl/QW9qoYsbc5UzLD+jx0ytA2ApWzE46wsr1IONpKXdEEK7EWIYHd+tr345jPQPCIzFsNKOBqykHdCpx900kMhG03hd+8HQrXTEyb4C9tvexd32VwmJUKIz85EFdTBrAGIESvWVBtzv2Xg2IEloed4OKTksbYIUX9nY4pVl8C/U5CMHecCS8jAtAHuXn9XriLdMwkKrlZt7I9CTfdpYEEvLUy+beGe7GX/AKjLU6Lfg9ZXUhxxH9BcaAGjywtRri2PNvncitGPhxHkHyuRkYjE2LFgYQJpYu61hcA2EfbWjZVdX3y7a9snKngERj7pE/yLQU6ZJ0kwaU/iNNTDeXYMiJsrERtyQwNwHhF8t+Nnjm9eam1O6lz4ULnoO13P9T0zy/8LqNQgufSSVOxs+kFvvCiKo/1ylbTmUNd7FEOpc05t5zBboUAz2QM1tX1g6NPf6+LCZLsuCKBWspCM8UApVr1Y8kdofg/iK6av40wQYicDBQzBtHyqjpRkVw== X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1189;5:7ErW0FBMpcc6uG1a1m6AHLvLCaCOXfC5/K1Y4rrDn6qjPB+NQMYaH6rEwi/Ip1KMFbyh7wyb25ZjGQGcajoUntvW6Ve/gOgXsloanVlDIOvA/bPTPYexM9UKVKwB3Gl8AV2kOGsgXvePrWP366vxmPOiqLwelufKUGyL10mCRvN11McOBsgNkDev19H72PuAGX+1C+gu9bvzl2jl/HR98qo8/h7Lerm9DhpJsagHueNR1DgoE5q5J0DptWZONp5dqQXD/U8m0k32ZcueDFlbsU9+dFVhMHkCBCo3SIrgtfmydKyT5oaFshJXaXDFIdFnmrcutYsmZXhMVwdSsUglUsaIODMdGUHHOyW+JJlP8X/zegZUXIGgavZdz8AEL/+ViZ190+Rq8KXHJrHHLl++6MF4T1U59MEgW2C78AwaAvsPREgojh8kqQxtW4PRKhVi3kEFSiwh/acHR94xHZuVCZ74ErKwoY9o7vJkGf/iR5trLjG8VB8FYF5gzrZYPJvW;24:BhEVmtDCDqppakGCIaYbTTjC3/WA/SZa8+NGbBEWY9T4QXINmVL3INVB1NeVAh10xUdkPdrVdFJ4u5+jTYvyG0l/tqeuMms1ZY2/q0Y209Q= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1189;7:xS5a2CGwpKTCQlNmQjjAPauluNOu7JvK2LQA8kAZVu1pxYZQHJcJK8EUr+W8Unh1Fwf1eVXPAAMjMcBkBMAG+JGf07vg/ohJjO3I6CoYevZJ6bOtstkfk0Gxc/WKzQWQ/YO6MjohU1Na9Chv/pgFdiD7359J/+V28X9VWNANo4GVZAGHCOF4WcgR9DTTbk8oFhYTdXHLx8ou/woOGeAc/Zfb2xhXTn7zTTOF9Lplgb/JnRUa3K3SrlhpuE7Ch0RMdoFMwLgORQkFrbGyKcUKooIZHVR/e4FOBEGsC7wNIlAaTODBX5fvv7x+luKsD5izWwJYX5KVKPGw7gn17tXVgw==;20:13p2vqrVku2tM7F3iNw09lVkusczJIO8rJggzQEXlQ+qhyl4m2ehhfiovTS+pOBXLpMmGth1Gs55QiWNftpJZgSI3uaCohPjbihuQw5fPDijwUt+N1sq1KRhDVoRzFm2z+MFZgD2PEn6KYMQKL1g5DXavlwrhcnQmDQouNJ8yTg= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2017 14:19:23.4669 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1189 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-09_07:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 786 Lines: 19 On 06/09/2017 04:19 AM, Arnd Bergmann wrote: > gcc points out an unusual indentation: > > drivers/block/loop.c: In function 'loop_set_status': > drivers/block/loop.c:1149:3: error: this 'if' clause does not guard... [-Werror=misleading-indentation] > if (figure_loop_size(lo, info->lo_offset, info->lo_sizelimit, > ^~ > drivers/block/loop.c:1152:4: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' > goto exit; > > This was introduced by a new feature that accidentally moved the opening > braces from one condition to another. Adding a second pair of braces > makes it work correctly again and also more readable. Thanks for fixing this Arnd, I did notice (and complained to Hannes) this yesterday. Added. -- Jens Axboe