Subject: Re: [RFC PATCH 2/3] Implement sysfs based cpuinfo for x86 cpus.
To: Thomas Renninger <trenn@suse.de>, Greg KH <gregkh@linuxfoundation.org>
References: <1496940975-9164-1-git-send-email-fschnizlein@suse.com>
 <1496940975-9164-3-git-send-email-fschnizlein@suse.com>
 <20170608182401.GC13995@kroah.com> <1956244.ag6eOoJRYo@skinner>
Cc: Felix Schnizlein <FSchnizlein@suse.com>, yanmin.zhang@intel.com,
        linux-kernel@vger.kernel.org, x86@vger.kernel.org
From: Brice Goglin <Brice.Goglin@inria.fr>
Message-ID: <593ABD2B.4040701@inria.fr>
Date: Fri, 9 Jun 2017 17:22:19 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Icedove/38.8.0
MIME-Version: 1.0
In-Reply-To: <1956244.ag6eOoJRYo@skinner>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1794
Lines: 61


Le 09/06/2017 15:28, Thomas Renninger a ?crit :
> On Thursday, June 08, 2017 08:24:01 PM Greg KH wrote:
>> On Thu, Jun 08, 2017 at 06:56:14PM +0200, Felix Schnizlein wrote:
>>> ---
>>>  arch/x86/kernel/Makefile        |   1 +
>>>  arch/x86/kernel/cpuinfo_sysfs.c | 166 
> ++++++++++++++++++++++++++++++++++++++++
>>>  drivers/base/cpuinfo.c          |   4 -
>>>  3 files changed, 167 insertions(+), 4 deletions(-)
>>>  create mode 100644 arch/x86/kernel/cpuinfo_sysfs.c
>>>
>> When you add new sysfs entries, you have to also add new
>> Documentation/ABI/ entries.
> This one seem to be rather unmaintained?
> There even is:
> Documentation/ABI/stable/sysfs-devices-system-cpu
> this patchset would have to add:
> Documentation/ABI/stable/sysfs-devices-system-cpu-cpuinfo
> then.
>
> But:
> Documentation/ABI/stable/sysfs-devices-system-cpu
> describes
> /sys/devices/system/cpu/dscr_default
> and
> /sys/devices/system/cpu/cpu[0-9]+/dscr
>
> which I have never seen.
>
> Much more important values in there like:
> /sys/devices/system/cpu/topology
> /sys/devices/system/cpu/microcode
> /sys/devices/system/cpu/cpuidle
> /sys/devices/system/cpu/cpufreq
> /sys/devices/system/cpu/{online,offline}

They are documented in
Documentation/ABI/testing/sysfs-devices-system-cpu (which doesn't
contain dscr)

Brice


>
> are not described there at all.
>
> I wonder whether .../cpu/dscr_default still exists in the
> kernel, a quick grep did not reveal anything.
> A
> Source:
> tag would be a nice non-optional addition in the README.
>
> We can also send definitions for topology/microcode/cache/..
> to catch up a bit there again, not sure that makes much sense.
>
> Be aware that the output of /proc/cpuinfo is rather arbitrary
> depending on architecure and some build options.
>
>       Thomas