Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751763AbdFIPXk (ORCPT ); Fri, 9 Jun 2017 11:23:40 -0400 Received: from esa6.hgst.iphmx.com ([216.71.154.45]:49191 "EHLO esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751562AbdFIPXj (ORCPT ); Fri, 9 Jun 2017 11:23:39 -0400 X-IronPort-AV: E=Sophos;i="5.39,317,1493654400"; d="scan'208";a="25442380" From: Bart Van Assche To: "linux-kernel@vger.kernel.org" , "gregkh@linuxfoundation.org" CC: "faisal.latif@intel.com" , "hal.rosenstock@gmail.com" , "linux-rdma@vger.kernel.org" , "dledford@redhat.com" , "sean.hefty@intel.com" Subject: Re: [PATCH 02/11] IB: nes: convert to use DRIVER_ATTR_RW Thread-Topic: [PATCH 02/11] IB: nes: convert to use DRIVER_ATTR_RW Thread-Index: AQHS4QGvs6M++wXUfkqpah/yNMvE/6IcprQA Date: Fri, 9 Jun 2017 15:23:35 +0000 Message-ID: <1497021814.2710.2.camel@wdc.com> References: <20170609090314.13991-1-gregkh@linuxfoundation.org> <20170609090314.13991-2-gregkh@linuxfoundation.org> In-Reply-To: <20170609090314.13991-2-gregkh@linuxfoundation.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=sandisk.com; x-originating-ip: [63.163.107.100] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1536;7:hy4T8Y3MRBpnwFNdhi8+rp743RgtcdSuSSVSITTFqjHqcXxhhhjr8xHlcHClmersN8oKRt+zy7UiYMieNL1O6VlTiifT8cTj/1Vaut2rIEj0WeDwzDVJMJnDcI7G/vbmdSS6Ey7DEOSuM4QIlYXkqTNhOxq64lVnMy7Ww/dsL2QtbOnwWR6+Aq6emtfqo9I9l8nq6yO23TgV19jmFb+aTYPlAw4HTl+TKr76dVjox13yXEfFlxjyXYciF1U2xfySj6BGRbc90zgayOqL0m0KTY3EU9UrKEyqfOTVryy+3f7DoHBuabS6iMYZe+tW8/7WR/L+DesgLziW+/7kPLs33Q==;20:m4skbZYmP9SxoMZWu0dipFtF3mJ53NZ7qBn5xOGyL8b10GMc49umdQ1uUmXFT8MmMJX+wOxCieSthM47u4o50apSPhvfzWTqB7zsKPVgzlHD8zMJPAzd/t6kixKyJXQjvO8mZKHWwF9lA+Rho7dj235VnzzsC901VwqvPqi6bXw= x-ms-traffictypediagnostic: CY1PR0401MB1536: x-ms-office365-filtering-correlation-id: 87eb9a2c-e68b-4755-038e-08d4af4b7f6d x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081);SRVR:CY1PR0401MB1536; wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(42932892334569); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(100000703101)(100105400095)(6055026)(6041248)(20161123558100)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123564025)(20161123562025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR0401MB1536;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR0401MB1536; x-forefront-prvs: 03333C607F x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39450400003)(39850400002)(39840400002)(39400400002)(39410400002)(39860400002)(24454002)(377424004)(25786009)(2501003)(6116002)(102836003)(14454004)(3846002)(103116003)(54356999)(3660700001)(76176999)(3280700002)(50986999)(558084003)(4326008)(305945005)(39060400002)(5660300001)(7736002)(72206003)(38730400002)(478600001)(53936002)(6246003)(6512007)(9686003)(99286003)(54906002)(122556002)(6436002)(6506006)(6486002)(77096006)(229853002)(33646002)(86362001)(2906002)(2900100001)(66066001)(36756003)(189998001)(2950100002)(8676002)(8936002)(81166006);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1536;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jun 2017 15:23:35.8997 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1536 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v59FNna8003061 Content-Length: 314 Lines: 6 On Fri, 2017-06-09 at 11:03 +0200, Greg Kroah-Hartman wrote: > We are trying to get rid of DRIVER_ATTR(), and all of the nes.c driver > attributes can be trivially changed to use DRIVER_ATTR_RW(), making the > code smaller and easier to manage over time. Reviewed-by: Bart Van Assche