Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751772AbdFIP6X (ORCPT ); Fri, 9 Jun 2017 11:58:23 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:59294 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751633AbdFIP6U (ORCPT ); Fri, 9 Jun 2017 11:58:20 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=fb.com; Subject: Re: [PATCH][-next] loop: fix incorrect nesting levels on braces in nested if statements To: Colin King , Ming Lei , Hannes Reinecke , Omar Sandoval , Andrew Morton CC: , References: <20170609155425.21260-1-colin.king@canonical.com> From: Jens Axboe Message-ID: <7929f1eb-d796-6eba-52de-3c19ddcd2723@fb.com> Date: Fri, 9 Jun 2017 09:57:49 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170609155425.21260-1-colin.king@canonical.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [216.160.245.98] X-ClientProxiedBy: BN6PR1601CA0020.namprd16.prod.outlook.com (10.172.104.158) To DM5PR15MB1193.namprd15.prod.outlook.com (10.173.209.11) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR15MB1193: X-MS-Office365-Filtering-Correlation-Id: 032ee7b2-401b-49b4-2fdc-08d4af504a31 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:DM5PR15MB1193; X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1193;3:nEbgOSNmQS2kbNEU6O2iY3P/AY9YsVOJCHYRV0w6FjyMMN1atTeCbWTK/cRgAner0kvoP54FIN1nS42wu2rwIBDU1HTj/eObbrM3NGJik4zKf6JIWe6gqv7jBu6AhmytOaNAHOM+Vul+yZuZ3vbwf7z33ph0PWHh+olnDWcW9XFIj16Phs9mLSjKzidnToykUyM+DWFT0ddfZYy/2I/558kiUwyOqxZAVTFzPwqmnxfPwb+Ep04JGASL5/YZNmvwbiIFN4knXpBNfmXow5mswLYK+uwl7j3oml94Cr466KB5R18fojprUXk0Zp0FEkuZJIxm52GkBaM4xkFtRW0IOw==;25:uGKQzOTtJ9h9FsxvI4f5ooeCbYdO8Y3UqfpoTRpHLwv+sO4H65PH11bexoolaB5uraGlX5LNZra+nRoBHgk0NJ2JYjlNewmuJE35LcvGaRbZdarniZUaxheeM8J0Z1Zrn7RYuoo40ykuXqoOBkixIKUuyj4dndo5FubGWdy3nttx27wPY8RgLNjND23bHHAbqeEZcCHm6xApM3kfu8DhmK4C/E4gezrgZoWYl3kp7EmtY6e9RGadf8JC4bC81cU3RYL6LKEuzr4xN5QEX0pRvuSWsnHxhm/LKsFLCKSUcdrai28Y8/t9CA2tLV4IQFVVd6SKogkmp6pwSbZTCmzSlKaSlNS+5C1Ny7K4SCO5aFXiHuvjC7W9DXaNna6nFXkGZrTwzggLy9npDCuJGSTTo3cajhltJAfCT4OGq6ZnAbbv4Ne409xwFle0U4+ZCmGSJxesZR++2at5j1coO6m87YUCsWgMAuIp5mUR+FzK16g= X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1193;31:xR4AIFoPoB410+zUYqQmUzTai6lK/48Ly7uemymslaJbkn7ZBtx5Kloft9gMc1M4Jf9MuR3StJA9/ep7cswHsTiMTE/aknuk8mWWKISvq+vI2vIV2wzlo0dtz/l2dt+pXsO4+47DNXQUmhAxwSJJOy5cCOO3bobH3ZHM5lLcLp9a0q7DPph9VRP8LXyHC5k2liVUyyfknfx4puP3xqweT0pQRuV7Vxk8j9FCW2VmB5Y=;20:dbw4Xrmhs2dRO2TxNwr4Q2uYut+qF1nARt/WYa0tmuPim4hANu4yv4VOV6/5dkRZKPy0NBQi2/hBbpoPeUZatbF8fvnbZuDQung+B0uhSEMi+vRlrxJk5zo5Qo7gez7ZF6suWH6iNphh/lf+ComCYSd2Cbxl3AROvd4gd3gMD3MxJJIcWXUBkCo0aXu/Kbxa0YDliDDm8jOsi7U2+sdWJgSLn6ZgHl9Oj87cYgKcpI87Jh3NOX+ReYj9NCYcXvBT98YPiGmCBMlBFOS78d4gvmau9VdXKZDmVi5+juFrTGU7quBAa3UJ1JeuYOStkctMIKOKxrHUVOqtoSPagAeSM4lpZoEfklFgjMIGJrvoXYs8E64p1Pg9v+EeX0pOp0whgvaWkPCRONaM/sC8ajRLtBIrZrUUnVndlvGFiEqJIM9SIUAZPxBzj1a0by+NcQ0MG0w6akVH0ZbW/7aN35morEaAC50jsYurNRjyIsQLlRiFT4Ex4VEs4DJwtm4w+ueH X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(198206253151910); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(100000703101)(100105400095)(6041248)(20161123558100)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123562025)(20161123564025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DM5PR15MB1193;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DM5PR15MB1193; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjE1TUIxMTkzOzQ6WUxpcVVqN2F4NVk5WitYVFBSMG0zYjBmV1Nl?= =?utf-8?B?OVdIeHlYOTF2RTNRZzh3TzZCbGNjdVM5V0tBMXhaaWJ0Ykt0OTRBT2l0TWNx?= =?utf-8?B?clV1Uk5iZi9wOTVjNldSa2dwKzdRbVl5ci80WG41MGlxK0E4NC9wMCtFcitR?= =?utf-8?B?TUVzd0p1cEhZMzJwMm1BRUdYbm1sa3A5L2FlS040K25BY21HTUNHSERVU0w3?= =?utf-8?B?UXQ1YUdJczVxUkhlUEo4N25pTTQ0YlA2ZlkrZG5qaE9lUjFieXV4UGlxYlV1?= =?utf-8?B?VTlaVmQ2Nk14eFVVcTkyVmtHWWdrS2NxazVMQmVzb1llVEw1UFdIVVk2OVVt?= =?utf-8?B?WUtQUFdDQXVoYXNmUDFWWmRGL01LS3kwWENTSkdLTUQ0R2p3UGwzdXNvcU1G?= =?utf-8?B?VUtjS2lyTlRsMy8wS09lWi81YzVReC95bk5xVjh0c1kwWE9WTGlaSnZuNS9M?= =?utf-8?B?OS9LQVdvNFpVVE9zS3pzS0U3Ym9GSHA2VHF3a1VIZHRmck1PZ0ZHRUlSYmhv?= =?utf-8?B?Z0h6Z2V5eHJlcnRQSWg0Nk9BcWJiejJKaFJVT0trYlNyZXdvZFdjbi8yYVpj?= =?utf-8?B?YVFFSmQwOGRKblcySlY5RmZIV3ZmVVYwUFZQdkFLK2wvVkZZS210VEI2V3Y3?= =?utf-8?B?dXBwQ3lENlF5UkpWQkpiczlZb1RYZ2FoV0lTWTljU2JsMjJiMHFNNGlIbDlr?= =?utf-8?B?TjlYVm8yUmU0cXBxekdVcjcxcjJSRzZoRm4rb1pMeGlCVEoyNkNDdGtodERi?= =?utf-8?B?MFNEUkczL2xSZUVrdTVvQVBTUHNOZVhmc3hXNWlXOGtlT2NzTDVGdzF5M0tw?= =?utf-8?B?Rlo1VUlYWGdYVnFuTnVHS0FqU21rM0ljaldkN01GNllOSnZmWGFCSHhLT0ds?= =?utf-8?B?U09xbHdQY3paTXRLd1hFcTBCcVVoeHNsemZpRDJIYUljdGZkNWZyb2ZkZHc5?= =?utf-8?B?cmhUbHZMZ2hHRUJyNzhSVnFpa29Yc1VVZjJXSVpaNTBLUnNIUTZBS3l4RnAz?= =?utf-8?B?Qy9BMXpyM2hJcXoyNU5sYlZBUnIvbHdVbGxIOVA3OW5pRDFadzBBdEpXNlNw?= =?utf-8?B?VFhMc0RMNVg5VnRVTXU2NUcwWUIxRTZNSFJlSCt0dTV4TnJkZ1Q5ejNrZ05O?= =?utf-8?B?YzQvS1FQdWF3Q2RYOVo3ZzRsOE1BSC9PRmNock1tU3Q4QWhiU3diVitjQVkz?= =?utf-8?B?VTFJdU9wOVlOcjlPNnhDbGt4RUg2VWNxQ1AvbUgwM0V4bkwyY2x6MUI3VUNp?= =?utf-8?B?RVFOWjFOMG15eDByV2tkTGYybG9RVGswQjQ2RVQ2V1lKRTFWbkM1UHlXWXBI?= =?utf-8?B?Z2EvRmFuY0xjNk9FOGoxQTIwYzVuWmJXM0c5eERxbFJtN2c2dWo3UnBzYk1l?= =?utf-8?B?UzFjYmQ3ZXRFa29RQWtpZjdVOW1nM1Z0a1dldUUrZVhvRVh6ek5pdStDRmhr?= =?utf-8?B?Q0JnemR0cDV1bVEvVHQwQm1MNmF3TGZXZHBKREMvZ1hWWm9Jb1RLNEpkb1Yx?= =?utf-8?B?MStMZG5ualZFUmNwWFNwL1R4SkREdDJzZkhWZEhKUGJQL3hTUzBpWms2REdQ?= =?utf-8?Q?TfYBpeiQSi10NmVxyn4fEHsqg39yNpqY3d/qp2KKWW8=3D?= X-Forefront-PRVS: 03333C607F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(39840400002)(39450400003)(39400400002)(39410400002)(39850400002)(377454003)(24454002)(189998001)(66066001)(47776003)(81166006)(8676002)(65806001)(23676002)(65956001)(229853002)(6246003)(3846002)(230700001)(38730400002)(25786009)(5660300001)(65826007)(6306002)(53936002)(53546009)(117156002)(7736002)(86362001)(6486002)(77096006)(90366009)(305945005)(966005)(478600001)(36756003)(42186005)(54356999)(4326008)(76176999)(31696002)(50986999)(2906002)(64126003)(33646002)(31686004)(2950100002)(6666003);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR15MB1193;H:[192.168.1.154];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjE1TUIxMTkzOzIzOjNPMGpEK2xOd1FNdlpqaHI5dnFiTzFaR3ZS?= =?utf-8?B?czFqazIxQmtFOHBGQzZ6S1QvaTRwdWZ2Qm1OOU1GWHNVRGxYREE1SkJnVUJm?= =?utf-8?B?QnVyNytOcUNwcW0vK3JPY2xYRHRTU2NBbWdENEFMQ3pwdWRYVUd2Mk56bkYw?= =?utf-8?B?ek4wTmdITW5LRnE4ZHIwdzZXY3YzaFVnMU5EQXN5T1NDL2x3TFBvUlNYSjEw?= =?utf-8?B?UjArNStJdHdLcjNOdExaUEhWQ0EvMWpWMkUyQllUYllDVnljbnJGTUxjVFl4?= =?utf-8?B?NW93UlJobjJERytKdi9lSGdKeEI4cGNjQkordnFNejY0K3FWMmFsNTNKY1Ft?= =?utf-8?B?WWF6M25EbUFHZ0VoMlBWVGkzUXpBOGt5dGMzSnBEenZndGFnZjFkUEpUa2pP?= =?utf-8?B?UkwwU296Nm5vVDE1blg1Mm9ZenlKZW9jME5kMGhCSjdGOHVVTnFRakRvMG0y?= =?utf-8?B?amtBcTJCekY0MjBSK1dEKzN3SHA5SW95OENqNHRlU1d1SFBLUVBEV3VLbTNP?= =?utf-8?B?TkZEYUJGS2tqaGg4L3JrcjhLeFFSZmF3eVZZNktGcDBDaUJLOEZMUmxZNEVH?= =?utf-8?B?WUdjV2hPNGhORitsZ01YeHo2TEYrbkdTVnh1QWZJTWd0OGtQcXVGSkFGV2JQ?= =?utf-8?B?OHRkcWpzVGk0NmdNeWtTUXkxUWJPSjVuaXlzMTN1U0pyZzNTbG1PSXNTM1pj?= =?utf-8?B?dnhRYWk0WHdXUU1IMmdtMm5pRmdxMnc1ZnYxWFRuVHNVUEdreTZnL3kxbndJ?= =?utf-8?B?c0gxQi9hWW9iWE9qVkN4aThsYmI3R3YyWktWdm5OY2doRzZjUnRWWkc1cTRR?= =?utf-8?B?and4QWhycUhrOUJMZjRjNENlOGZBUEFtdjl3c0M0Qi9aMUErVW5SRjNpL0Zx?= =?utf-8?B?WGdJRllqOXpKbHdmL3BpdFZuRnNWcUpKZWhlakcxdy8yajZUNUg4VFN0aERV?= =?utf-8?B?YnJnNFNqcTNSY2xlcW84YzdQbnV3Qmp6SGdwWE5kdDdPRElMc0xmRnRCM2Zp?= =?utf-8?B?Tnl2M2J2UjBiMVdqV3NWS2doK0U5RkxxbkpsZjd2UEpuWFNFNmNYdzd1UDJj?= =?utf-8?B?YTFiZFhVaWh5dHFNTjF2QUJUcEoxeDMzODdhREdnZEMzS3RyVldKM2pWUk14?= =?utf-8?B?RThBTGVkYXBnZndla1RmbUMvL1pONVlZN29uMHlXTFc2V2M1MEFCeStCR2Ni?= =?utf-8?B?NUEvZ2JUMjBLOFRvSjQxUmJBSkRpYkxYMDJSUHlwVDRLcWUxVzBFVXJRbTZa?= =?utf-8?B?aHRvNWRSS0pjS2pFOWpnSktlSlBZOGU0WmN5MEJFakNncDlGYkF6Y1cxeU5T?= =?utf-8?B?SURrWmQ0c2pUWmk4Uk9xL3NrRk1XY1FJT1NXYlNpOE1oS2RSZkcxbGIvSkta?= =?utf-8?B?RkNObVZjZHJuOU13K21LcWczaW40d2NCdXJaSWhQck55MSt6eHdmaVRhK2w5?= =?utf-8?B?WnVOYTFYd2VYR1E0RStDNGcxNG5wVjRSNkl3YW9Ba3dESG8yMzhnV2tZS3Bh?= =?utf-8?B?ZlM0a1dSU1RCa05jcE82Zk9qendKblBlUWVYT2p5U1NGdHM3VGNWbFpvSUNu?= =?utf-8?B?ZDJsSnlWR2JMVmt4QmhDd29WZlg5bVQ5NGZKUEZEV2lxNDdVWWhRM3BJWTJ4?= =?utf-8?B?L1ZCdVd4NHNpd2NTSUdIRTRYU2FadVEzWWYvaE5ZL1ByMGg3WEVwOTQ1NmR0?= =?utf-8?Q?O/0vIjZHfE5SEJ4fbQ=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1193;6:l1BhhPG9AOt2xtCBMVJDwG+7E8qCqvU+eGzWsFIYqfOC76A6bNLTxdkBCE3CwYm2/KcS5uEsrgfYB/ARFya2vFqJGoBKWz94c0bzHOaLElNwzZIQm4qVs7mHErZXzcPHMDqhxWYyDpAWcwWPZl1Y17mSCZ/4u9bnFtdN764xTGhlVzKRAi/n6mULtC/WU4jDKaaglARcOEdb6oPEBCK45Obbl6PewWwX0WZeNGL5kbcKTRh3JoWPp6wbGYB6E4wenmMsqheI+i6928oERa7+pBgL+xQl6M1YBkabYslzG0vVx4zf6Kup1Y7pl4JzPhyxjJEGfIqHB1kIWTjxi9NxBzUeDduz2dDOuBj3hPNdBxxwNlQfHP3+lWLUjxzOrfSgJ/IEQ0K8f1mFEftklX2aAQ4FehJA+tLgUzCr+qaKM+RXyxA28diNYZcPk3RChHEY3zBlqWxtXmZECNq4kfSGy9Vzv3Zit2LclQQJlBPMAx7ba54wi0rlxDxxXIk3rrvICMW2AXpftzSEpaWcSHV4Jw== X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1193;5:zbe3aJF7JbnDgeKWFr3Kjxbi1egOmcsnge2XqgZewIart7KjACQwXJ5KZ4m53Xe0zgO0T4HQ4eE3nmykrEhkNE9kgIkGJu43rq4vvnCuQa+JHzNRM7d3LQ2EiDzRfDyNQWyZUmWk8PW4R3pu/Dv8di8Ki+AURb7hcg9S0I6QTN8m6/vuo6ZbvDgFJYB2edSsd0oVhvBAhwjzSlR09IaPM0iAEqxoPpw44nzV8iXgw6JzijJGNKPBd7qXSKu1ij2PFAxowkAI/UKji0YxDvcgiNJSC8//HccEnP02E0SPj6xHxVlw7Ly9A3KEvdb7WHFhKmP3CeRnAKmlNAlsoaHNIA94LdT7jEJ9ZZz8vF+hpLNoKj+is2TIkfSoHff1uZRXD13ijgZim73fmPGc3HFLoycCzfz0fB8yIv95Qbalvv0PjEi/muUhFC4ZRikIrv47Aa/8Ql/5LTO9hgX4YUI/rZsN29PIpHv8i8oWsOxbYy15UMnAJadUyNvl7eLqV9VA;24:epVWXxhBm/gZD9A7/iB5GDFY7OkqtoUjHwM/1NKz/jwqLPzyM1yvqWPQ3EjhhNX1qPoCl6dm5HpC9TAf4Iuejwq5u1M15yKi9t1VuxxGRkU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR15MB1193;7:WKbU/V79bcqzourgJJMvhneWhhQwxr/aMZgQUjKq8fvRuloPLNrlDetzumrcLOXAS6vfAbJkNKMLZubNlNtC+N9EwEVB3FW2auHEJsaSWomddgDNaLeWfWRJcWw9c+WUtzoiqb9ozKf3KNEAPjYskkpmbjFQp38OmAlu47b3a47c4HmwvST/3xyikrW3sWFutIHUhz4J4pQuTd0KnceQ1PCQ98L/EbThdAuRANjv1l1jy4BH/Qlena1FZV1eepoerrp2hnzrzqcYW1aKQ9MFV8oTt9MewKZJFBVBwj3TCcrg32H62gdhChnKtW0huFKeJh4f/iLhDvS6L0pb3VfKPA==;20:KO74AGGrNMPj8htUIinbxQS/QxgggVaaA/5bw7FcJ/Y5icu5I0if/unShw1BAyzNdW0B6zyS/Q3Ea5/sMQtmRM3502h12m4py7qXZ6xNuZQD7uED9EiX9AO8L4oK9tTpNI3Jbpln4MBmDMmDhKMK8KJA5oI91XJMGA+Uop0alMo= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2017 15:57:53.2908 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR15MB1193 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-09_07:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 489 Lines: 16 On 06/09/2017 09:54 AM, Colin King wrote: > From: Colin Ian King > > Adding another set of braces clarifies the block and ensures that > both the setting of err and the error exit are executed on the > deepest nested if statement. > > Detected by CoverityScan, CID#1440959 ("Nesting level does not > match indentation") Already fixed: http://git.kernel.dk/cgit/linux-block/commit/?h=for-4.13/block&id=b040ad9cf6a169cc000a5324fcada695dfa1f4b3 -- Jens Axboe