Date: Mon, 9 Jun 2003 23:07:07 +0200
From: Pavel Machek <pavel@suse.cz>
To: Patrick Mochel <mochel@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC] New system device API
Message-ID: <20030609210706.GA508@elf.ucw.cz>
References: <20030609184233.GA201@elf.ucw.cz> <Pine.LNX.4.44.0306091323340.11379-100000@cherise>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.44.0306091323340.11379-100000@cherise>
User-Agent: Mutt/1.5.3i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1361
Lines: 32

Hi!

> > You are currently adding more methods and semantics just to make
> > system devices separate from "normal" ones. If you keep two-stage
> > (actually three-stage suspend), you'll have system devices similar to
> > normal ones, and will have less special cases to care about.
> 
> The whole point of doing this is because system devices are not regular 
> devices and shouldn't be treated as such. This actually simplifies the 
> requirements for representing system devices in the device hierarchy, 
> despite adding new functions..

Okay, but you should keep "new" functions as similar to existing ones
as possible. That means 3 parameters for suspend functions, and as
similar semantics to existing callbacks as possible.

> > And keyboard controller with its devices needs to be suspended
> > early/resumed late because both operations are likely to need
> > interrupts.
> 
> So? A keyboard controller is not classified as a system device.

Its not on pci, I guess it would end up as a system device...
								Pavel
-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/