Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751834AbdFIQMe (ORCPT <rfc822;w@1wt.eu>);
        Fri, 9 Jun 2017 12:12:34 -0400
Received: from conssluserg-05.nifty.com ([210.131.2.90]:53092 "EHLO
        conssluserg-05.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751754AbdFIQMc (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 9 Jun 2017 12:12:32 -0400
DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-05.nifty.com v59GCNtX026219
X-Nifty-SrcIP: [209.85.213.177]
MIME-Version: 1.0
In-Reply-To: <CABxcv=msBQVW2P+RkcAq+5jhBkMorZvToaGDoLF6rT_knb3qhw@mail.gmail.com>
References: <20170523133448.4794-1-javier@dowhile0.org> <20170523133448.4794-13-javier@dowhile0.org>
 <CAK7LNATDvesYLKimY=aKfT6kAiidq6Ufd=kCWGQcCZ_Xy-27tw@mail.gmail.com>
 <CABxcv=mPzDVTh_ZH1VtuHMUhVrR+hxz8GwcQT38hwJJqHY+fJA@mail.gmail.com>
 <CAK7LNASBztX033t36vz_MXAgeyHd76roMBtRZ4mi-q9VFB4Lkg@mail.gmail.com> <CABxcv=msBQVW2P+RkcAq+5jhBkMorZvToaGDoLF6rT_knb3qhw@mail.gmail.com>
From: Masahiro Yamada <yamada.masahiro@socionext.com>
Date: Sat, 10 Jun 2017 01:12:22 +0900
X-Gmail-Original-Message-ID: <CAK7LNASTTubkm7xV4FbcPwNCcz9TgeOswzK4Rn=FpB0oOSRmpQ@mail.gmail.com>
Message-ID: <CAK7LNASTTubkm7xV4FbcPwNCcz9TgeOswzK4Rn=FpB0oOSRmpQ@mail.gmail.com>
Subject: Re: [PATCH v5 12/20] ARM: dts: uniphier: Add generic compatible
 string for I2C EEPROM
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Wolfram Sang <wsa@the-dreams.de>, Rob Herring <robh@kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Russell King <linux@armlinux.org.uk>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1079
Lines: 41

2017-06-07 21:42 GMT+09:00 Javier Martinez Canillas <javier@dowhile0.org>:
> Hello Masahiro,
>
> On Wed, Jun 7, 2017 at 3:10 AM, Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
>
> [snip]
>
>>>>
>>>> Why didn't you touch
>>>> arch/arm/boot/dts/uniphier-ref-daughter.dtsi ?
>>>>
>>>
>>> Because the compatible string "microchip,24lc128" used by the I2C
>>> EEPROM node on that DTS is not supported by the
>>> drivers/misc/eeprom/at24.c driver (in fact the only occurrence for
>>> 24lc128 I see is in that DTS).
>>>
>>> Maybe is a typo and it should be "microchip,24c128" instead ?
>>
>> I do not think so.
>> I consulted a board developer.
>>
>> I also see 24LC128 on Microchip web site:
>> http://www.microchip.com/wwwproducts/en/24LC128
>>
>
> Ah Ok, it was just a wild guess I did since the at24 driver didn't
> have support for this chip variant.
> My point stands though, this is an unrelated change to the goal of
> this patch-series and should be fixed separately.
>
> Best regards,
> Javier


Applied to linux-uniphier.  Thanks!

-- 
Best Regards
Masahiro Yamada