MIME-Version: 1.0
In-Reply-To: <20170609140413.7e7ba9e3@gandalf.local.home>
References: <20170609132736.13699-1-vkuznets@redhat.com> <20170609132736.13699-11-vkuznets@redhat.com>
 <20170609140413.7e7ba9e3@gandalf.local.home>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Fri, 9 Jun 2017 21:23:52 +0300
Message-ID: <CAHp75VeCHXfgXOgx_FwS197rnF6QcAstJwf4cr4g1bdkstx1xw@mail.gmail.com>
Subject: Re: [PATCH v8 10/10] tracing/hyper-v: trace hyperv_mmu_flush_tlb_others()
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>, devel@linuxdriverproject.org,
        "x86@kernel.org" <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "K. Y. Srinivasan" <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Jork Loeser <Jork.Loeser@microsoft.com>,
        Simon Xiao <sixiao@microsoft.com>, Andy Lutomirski <luto@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 555
Lines: 21

On Fri, Jun 9, 2017 at 9:04 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> On Fri,  9 Jun 2017 15:27:36 +0200
> Vitaly Kuznetsov <vkuznets@redhat.com> wrote:


>> +#if IS_ENABLED(CONFIG_HYPERV)
>
> Hmm, this is new to me. I know you can use IS_ENABLED() inside C code,
> but I've never seen it used for preprocessor directives. This usually
> is just:
>
> #ifdef CONFIG_HYPERV
>
> Other than that, this looks fine to me.

That is the magic of IS_ENABLED(), IS_BUILTIN() macros.
So, the code above is fine as is.

-- 
With Best Regards,
Andy Shevchenko