Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751768AbdFIScN (ORCPT <rfc822;w@1wt.eu>);
        Fri, 9 Jun 2017 14:32:13 -0400
Received: from mail.kernel.org ([198.145.29.99]:37252 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751730AbdFIScM (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 9 Jun 2017 14:32:12 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5CF623966
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org
Date: Fri, 9 Jun 2017 14:32:08 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>, devel@linuxdriverproject.org,
        "x86@kernel.org" <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "K. Y. Srinivasan" <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Jork Loeser <Jork.Loeser@microsoft.com>,
        Simon Xiao <sixiao@microsoft.com>, Andy Lutomirski <luto@kernel.org>
Subject: Re: [PATCH v8 10/10] tracing/hyper-v: trace
 hyperv_mmu_flush_tlb_others()
Message-ID: <20170609143208.69afd2e9@gandalf.local.home>
In-Reply-To: <CAHp75VeCHXfgXOgx_FwS197rnF6QcAstJwf4cr4g1bdkstx1xw@mail.gmail.com>
References: <20170609132736.13699-1-vkuznets@redhat.com>
        <20170609132736.13699-11-vkuznets@redhat.com>
        <20170609140413.7e7ba9e3@gandalf.local.home>
        <CAHp75VeCHXfgXOgx_FwS197rnF6QcAstJwf4cr4g1bdkstx1xw@mail.gmail.com>
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 935
Lines: 29

On Fri, 9 Jun 2017 21:23:52 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Fri, Jun 9, 2017 at 9:04 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> > On Fri,  9 Jun 2017 15:27:36 +0200
> > Vitaly Kuznetsov <vkuznets@redhat.com> wrote:  
> 
> 
> >> +#if IS_ENABLED(CONFIG_HYPERV)  
> >
> > Hmm, this is new to me. I know you can use IS_ENABLED() inside C code,
> > but I've never seen it used for preprocessor directives. This usually
> > is just:
> >
> > #ifdef CONFIG_HYPERV
> >
> > Other than that, this looks fine to me.  
> 
> That is the magic of IS_ENABLED(), IS_BUILTIN() macros.
> So, the code above is fine as is.
> 

I'm sure it works, but it just adds one more way of doing the same
thing. I thought that was what perl was always criticized for, and why
people usually prefer python. Don't get me wrong, I prefer oysters over
snakes. But I just wanted to point out the lack of consistency here.

-- Steve