Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751784AbdFISq5 (ORCPT ); Fri, 9 Jun 2017 14:46:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:38586 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751659AbdFISqz (ORCPT ); Fri, 9 Jun 2017 14:46:55 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 76FC322D40 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=luto@kernel.org MIME-Version: 1.0 In-Reply-To: <85355c4c-2cc1-daac-d8fe-ac6965b34606@amd.com> References: <20170607191309.28645.15241.stgit@tlendack-t1.amdoffice.net> <20170607191453.28645.92256.stgit@tlendack-t1.amdoffice.net> <85355c4c-2cc1-daac-d8fe-ac6965b34606@amd.com> From: Andy Lutomirski Date: Fri, 9 Jun 2017 11:46:32 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 10/34] x86, x86/mm, x86/xen, olpc: Use __va() against just the physical address in cr3 To: Tom Lendacky Cc: Andy Lutomirski , linux-arch , "linux-efi@vger.kernel.org" , kvm list , "linux-doc@vger.kernel.org" , X86 ML , kexec@lists.infradead.org, "linux-kernel@vger.kernel.org" , kasan-dev , "linux-mm@kvack.org" , iommu@lists.linux-foundation.org, Rik van Riel , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Toshimitsu Kani , Arnd Bergmann , Jonathan Corbet , Matt Fleming , "Michael S. Tsirkin" , Joerg Roedel , Konrad Rzeszutek Wilk , Paolo Bonzini , Larry Woodman , Brijesh Singh , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Andrey Ryabinin , Alexander Potapenko , Dave Young , Thomas Gleixner , Dmitry Vyukov Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2271 Lines: 63 On Thu, Jun 8, 2017 at 3:38 PM, Tom Lendacky wrote: > On 6/8/2017 1:05 AM, Andy Lutomirski wrote: >> >> On Wed, Jun 7, 2017 at 12:14 PM, Tom Lendacky >> wrote: >>> >>> The cr3 register entry can contain the SME encryption bit that indicates >>> the PGD is encrypted. The encryption bit should not be used when >>> creating >>> a virtual address for the PGD table. >>> >>> Create a new function, read_cr3_pa(), that will extract the physical >>> address from the cr3 register. This function is then used where a virtual >>> address of the PGD needs to be created/used from the cr3 register. >> >> >> This is going to conflict with: >> >> >> https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/commit/?h=x86/pcid&id=555c81e5d01a62b629ec426a2f50d27e2127c1df >> >> We're both encountering the fact that CR3 munges the page table PA >> with some other stuff, and some readers want to see the actual CR3 >> value and other readers just want the PA. The thing I prefer about my >> patch is that I get rid of read_cr3() entirely, forcing the patch to >> update every single reader, making review and conflict resolution much >> safer. >> >> I'd be willing to send a patch tomorrow that just does the split into >> __read_cr3() and read_cr3_pa() (I like your name better) and then we >> can both base on top of it. Would that make sense? > > > That makes sense to me. Draft patch: https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/commit/?h=x86/read_cr3&id=9adebbc1071f066421a27b4f6e040190f1049624 > >> >> Also: >> >>> +static inline unsigned long read_cr3_pa(void) >>> +{ >>> + return (read_cr3() & PHYSICAL_PAGE_MASK); >>> +} >> >> >> Is there any guarantee that the magic encryption bit is masked out in >> PHYSICAL_PAGE_MASK? The docs make it sound like it could be any bit. >> (But if it's one of the low 12 bits, that would be quite confusing.) > > > Right now it's bit 47 and we're steering away from any of the currently > reserved bits so we should be safe. Should the SME init code check that it's a usable bit (i.e. outside our physical address mask and not one of the bottom twelve bits)? If some future CPU daftly picks, say, bit 12, we'll regret it if we enable SME. --Andy