Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751728AbdFISyA (ORCPT <rfc822;w@1wt.eu>);
        Fri, 9 Jun 2017 14:54:00 -0400
Received: from lb2-smtp-cloud3.xs4all.net ([194.109.24.26]:46396 "EHLO
        lb2-smtp-cloud3.xs4all.net" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1751535AbdFISx7 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 9 Jun 2017 14:53:59 -0400
Message-ID: <1497034433.12817.17.camel@tiscali.nl>
Subject: Re: [PATCH v8 10/10] tracing/hyper-v: trace
 hyperv_mmu_flush_tlb_others()
From: Paul Bolle <pebolle@tiscali.nl>
To: Steven Rostedt <rostedt@goodmis.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>, devel@linuxdriverproject.org,
        "x86@kernel.org" <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "K. Y. Srinivasan" <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Jork Loeser <Jork.Loeser@microsoft.com>,
        Simon Xiao <sixiao@microsoft.com>, Andy Lutomirski <luto@kernel.org>
Date: Fri, 09 Jun 2017 20:53:53 +0200
In-Reply-To: <20170609143208.69afd2e9@gandalf.local.home>
References: <20170609132736.13699-1-vkuznets@redhat.com>
         <20170609132736.13699-11-vkuznets@redhat.com>
         <20170609140413.7e7ba9e3@gandalf.local.home>
         <CAHp75VeCHXfgXOgx_FwS197rnF6QcAstJwf4cr4g1bdkstx1xw@mail.gmail.com>
         <20170609143208.69afd2e9@gandalf.local.home>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 523
Lines: 16

On Fri, 2017-06-09 at 14:32 -0400, Steven Rostedt wrote:
> I'm sure it works, but it just adds one more way of doing the same
> thing. I thought that was what perl was always criticized for, and why
> people usually prefer python. Don't get me wrong, I prefer oysters over
> snakes. But I just wanted to point out the lack of consistency here.

A major benefit is that
    #if IS_ENABLED(CONFIG_HYPERV)

is shorter than
    #if defined(CONFIG_HYPERV) || defined(CONFIG_HYPERV_MODULE)

and less prone to typos.


Paul Bolle