Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751635AbdFITwM (ORCPT ); Fri, 9 Jun 2017 15:52:12 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:38410 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751581AbdFITwL (ORCPT ); Fri, 9 Jun 2017 15:52:11 -0400 Date: Fri, 09 Jun 2017 15:52:09 -0400 (EDT) Message-Id: <20170609.155209.1236904196625042254.davem@davemloft.net> To: arnd@arndb.de Cc: Yuval.Mintz@cavium.com, Ariel.Elior@cavium.com, everest-linux-l2@cavium.com, Manish.Chopra@cavium.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] qed: add qed_int_sb_init() stub function From: David Miller In-Reply-To: <20170609103744.3239316-1-arnd@arndb.de> References: <20170609103744.3239316-1-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 09 Jun 2017 12:10:31 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 664 Lines: 15 From: Arnd Bergmann Date: Fri, 9 Jun 2017 12:37:35 +0200 > When CONFIG_QED_SRIOV is disabled, we get a build error: > > drivers/net/ethernet/qlogic/qed/qed_int.c: In function 'qed_int_sb_init': > drivers/net/ethernet/qlogic/qed/qed_int.c:1499:4: error: implicit declaration of function 'qed_vf_set_sb_info'; did you mean 'qed_mcp_get_resc_info'? [-Werror=implicit-function-declaration] > > All the other declarations have a 'static inline' stub as an alternative > here, so this adds one more for qed_int_sb_init. > > Fixes: 50a207147fce ("qed: Hold a single array for SBs") > Signed-off-by: Arnd Bergmann Applied, thank you.