From: stillcompiling@gmail.com
To: Anatolij Gustschin <agust@denx.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Alan Tull <atull@kernel.org>, linux-kernel@vger.kernel.org,
        linux-fpga@vger.kernel.org, Moritz Fischer <moritz.fischer@ettus.com>,
        delicious.quinoa@gmail.com, Joshua Clayton <stillcompiling@gmail.com>
Subject: Re: [PATCH 06/10] fpga manager: Add altera-ps-spi driver for Altera FPGAs
Date: Fri, 09 Jun 2017 15:07:54 -0700
Message-ID: <88068505.BWkoHaDEJR@jclayton-pc>
User-Agent: KMail/5.2.3 (Linux/4.10.0-21-generic; KDE/5.31.0; x86_64; ; )
In-Reply-To: <20170609151840.2ea43706@crub>
References: <20170605190741.10508-1-atull@kernel.org> <20170609095112.GA24855@kroah.com> <20170609151840.2ea43706@crub>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1103
Lines: 33

On Friday, June 9, 2017 3:18:40 PM PDT Anatolij Gustschin wrote:
> On Fri, 9 Jun 2017 11:51:12 +0200
> Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
> ...
> 
> >I get the following build error with this patch:
> >
> >ERROR: "__spi_register_driver" [drivers/fpga/altera-ps-spi.ko] undefined!
> 
> it is due to enabled COMPILE_TEST and disabled CONFIG_SPI.
> 
> >So I'll just ignore this whole series, can you fix these issues up and
> >resend?
> 
> would "depends on SPI || (COMPILE_TEST && SPI)" in Kconfig be a proper
> fix for this? Anyone an idea?
> 

> Thanks,
> Anatolij
I don't think that ends up being any different than "depends on SPI"
But, it is an SPI slave driver driver, after all.
COMPILE_TEST is intended to build stuff that can't work due to a lack of 
hardware support, or lack of crosscompiler.
"selects SPI" would work, but is discouraged.

I just built successfully on native x86_64 with no problem, by enabling SPI.
"depends on SPI" is the right thing here.
I'm not sure when || COMPILE_TEST sneaked in there.

I'll submit a v13 with that small change.
-- 
~Joshua A Clayton