Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751676AbdFIWMJ convert rfc822-to-8bit (ORCPT ); Fri, 9 Jun 2017 18:12:09 -0400 Received: from mga11.intel.com ([192.55.52.93]:54044 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751560AbdFIWMH (ORCPT ); Fri, 9 Jun 2017 18:12:07 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,320,1493708400"; d="scan'208";a="1180570533" From: "Mani, Rajmohan" To: Sakari Ailus , Andy Shevchenko CC: "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-acpi@vger.kernel.org" , Lee Jones , Linus Walleij , "Alexandre Courbot" , "Rafael J. Wysocki" , "Len Brown" Subject: RE: [PATCH v1 1/3] mfd: Add new mfd device TPS68470 Thread-Topic: [PATCH v1 1/3] mfd: Add new mfd device TPS68470 Thread-Index: AQHS3rzDUwzdXHBE9EWhe+UestVvKKIYQW6AgAGBMwCAA1pnoA== Date: Fri, 9 Jun 2017 22:12:06 +0000 Message-ID: <6F87890CF0F5204F892DEA1EF0D77A59725BECB0@FMSMSX114.amr.corp.intel.com> References: <1496750118-5570-1-git-send-email-rajmohan.mani@intel.com> <1496750118-5570-2-git-send-email-rajmohan.mani@intel.com> <20170607115827.GY1019@valkosipuli.retiisi.org.uk> In-Reply-To: <20170607115827.GY1019@valkosipuli.retiisi.org.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.1.200.108] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 905 Lines: 27 Hi Andy, > On Tue, Jun 06, 2017 at 03:59:49PM +0300, Andy Shevchenko wrote: > > On Tue, Jun 6, 2017 at 2:55 PM, Rajmohan Mani > wrote: > > > The TPS68470 device is an advanced power management unit that powers > > > a Compact Camera Module (CCM), generates clocks for image sensors, > > > drives a dual LED for Flash and incorporates two LED drivers for > > > general purpose indicators. > > > > > > This patch adds support for TPS68470 mfd device. > > > > I dunno why you decide to send this out now, see my comments below. > > > > > +static int tps68470_chip_init(struct tps68470 *tps) { > > > + unsigned int version; > > > + int ret; > > > > > + /* FIXME: configure these dynamically */ > > > > So, what prevents you to fix this? > > Nothing I suppose. They're however not needed right now and can be > implemented later on if they're ever needed. > Ack