Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751803AbdFIXSm (ORCPT ); Fri, 9 Jun 2017 19:18:42 -0400 Received: from mail.ispras.ru ([83.149.199.45]:48106 "EHLO mail.ispras.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751597AbdFIXSl (ORCPT ); Fri, 9 Jun 2017 19:18:41 -0400 From: Alexey Khoroshilov To: Greg Kroah-Hartman , Yurii Zubrytskyi , Jin Qian Cc: Alexey Khoroshilov , Lorenzo Stoakes , linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: [PATCH] goldfish_pipe: allocate memory with GFP_ATOMIC in spinlock context Date: Sat, 10 Jun 2017 02:18:26 +0300 Message-Id: <1497050306-7064-1-git-send-email-khoroshilov@ispras.ru> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1031 Lines: 26 get_free_pipe_id_locked() is called with spinlock held, so the patch replaces GFP_KERNEL with GFP_ATOMIC to avoid sleeping in atomic spinlock context. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/platform/goldfish/goldfish_pipe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c index 2de1e603bd2b..5f3672153b12 100644 --- a/drivers/platform/goldfish/goldfish_pipe.c +++ b/drivers/platform/goldfish/goldfish_pipe.c @@ -704,7 +704,7 @@ static int get_free_pipe_id_locked(struct goldfish_pipe_dev *dev) /* Reallocate the array */ u32 new_capacity = 2 * dev->pipes_capacity; struct goldfish_pipe **pipes = - kcalloc(new_capacity, sizeof(*pipes), GFP_KERNEL); + kcalloc(new_capacity, sizeof(*pipes), GFP_ATOMIC); if (!pipes) return -ENOMEM; memcpy(pipes, dev->pipes, sizeof(*pipes) * dev->pipes_capacity); -- 2.7.4